-
Notifications
You must be signed in to change notification settings - Fork 1.5k
KEP-5313: Placement Decision API for multicluster scheduling #5314
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: master
Are you sure you want to change the base?
Conversation
Hi @mikeshng. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@mikeshng: GitHub didn't allow me to assign the following users: zhiying-lin. Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cc @awels |
@iholder101: GitHub didn't allow me to request PR reviews from the following users: awels. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
9ca10ab
to
3406d3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to simplify it a bit.
At the same time, will try to suggest sharing our MCO one as the placement.
3406d3d
to
881956f
Compare
280c3b3
to
971facb
Compare
Closed threads I believe are resolved. Feel free to reopen or comment if there's more to discuss. Thanks! |
971facb
to
f04fa5a
Compare
This looks good to me. There are a few typos etc. but we can take care of that later (I’ll follow up). I take it we’ll revisit the graduation criteria, test plans etc. after the initial merge, is that right? /lgtm @JeremyOT ping |
/ok-to-test |
Signed-off-by: Mike Ng <ming@redhat.com>
f04fa5a
to
272a8e6
Compare
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mikeshng The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Right, thanks @skitt ! Just pushed the update-toc check fix. |
/sig multicluster