Skip to content

KEP-5313: Placement Decision API for multicluster scheduling #5314

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mikeshng
Copy link
Contributor

  • One-line PR description: Add a new KEP to introduce the Placement Decision API for multicluster scheduling
  • Other comments:

/sig multicluster

@k8s-ci-robot k8s-ci-robot added sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 17, 2025
@k8s-ci-robot k8s-ci-robot requested review from JeremyOT and skitt May 17, 2025 23:48
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 17, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @mikeshng. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 17, 2025
@mikeshng
Copy link
Contributor Author

@k8s-ci-robot
Copy link
Contributor

@mikeshng: GitHub didn't allow me to assign the following users: zhiying-lin.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @deads2k @RainbowMango @zhiying-lin

CC @corentone @elgnay @haoqing0110 @jnpacker @qiujian16 @ryanzhang-oss

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@iholder101
Copy link
Contributor

/cc @awels
FYI

@k8s-ci-robot
Copy link
Contributor

@iholder101: GitHub didn't allow me to request PR reviews from the following users: awels.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @awels
FYI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mikeshng mikeshng force-pushed the placement-decision-api branch from 9ca10ab to 3406d3d Compare May 19, 2025 16:02
Copy link

@corentone corentone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to simplify it a bit.

At the same time, will try to suggest sharing our MCO one as the placement.

@mikeshng mikeshng force-pushed the placement-decision-api branch from 3406d3d to 881956f Compare May 25, 2025 15:34
@mikeshng mikeshng force-pushed the placement-decision-api branch 4 times, most recently from 280c3b3 to 971facb Compare May 27, 2025 21:56
@mikeshng
Copy link
Contributor Author

mikeshng commented Jun 3, 2025

Closed threads I believe are resolved. Feel free to reopen or comment if there's more to discuss. Thanks!

@lauralorenz
Copy link
Contributor

Triage notes: Now waiting for @skitt and @JeremyOT feedback as recent community comments have been addressed and we feel it is ready for you all to look at!

@mikeshng mikeshng force-pushed the placement-decision-api branch from 971facb to f04fa5a Compare June 3, 2025 22:51
@skitt
Copy link
Member

skitt commented Jun 16, 2025

This looks good to me. There are a few typos etc. but we can take care of that later (I’ll follow up). I take it we’ll revisit the graduation criteria, test plans etc. after the initial merge, is that right?

/lgtm

@JeremyOT ping

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2025
@skitt
Copy link
Member

skitt commented Jun 16, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 16, 2025
Signed-off-by: Mike Ng <ming@redhat.com>
@mikeshng mikeshng force-pushed the placement-decision-api branch from f04fa5a to 272a8e6 Compare June 16, 2025 17:24
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mikeshng
Once this PR has been reviewed and has the lgtm label, please ask for approval from skitt. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mikeshng
Copy link
Contributor Author

This looks good to me. There are a few typos etc. but we can take care of that later (I’ll follow up). I take it we’ll revisit the graduation criteria, test plans etc. after the initial merge, is that right?

Right, thanks @skitt !

Just pushed the update-toc check fix.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.