Add new test for deepcopy #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
|
I appreciate the followup. Can we narrow this down and rename it to reflect the type that is being demonstrated. Specifically, a struct with a single member field that triggers the rendered code - that way each output test is trivial to look at and decide if changes are correct. It might mean 3 or 4 individual new dirs.. |
|
@thockin - yrw and sure, that makes sense. I will update the changes. Thanks!! |
spzala
force-pushed
the
newtestifelselint
branch
2 times, most recently
from
4c78c60 to
331d9bf
Compare
|
@thockin - Hi Tim, as you could tell I am new to Go, but have tried to identify new types and added tests for them. Hope that makes sense. Thanks!! |
This was referenced May 15, 2017
thockin
reviewed
May 16, 2017
| } | ||
|
|
||
| type Ttest struct { | ||
| i []Inter |
There was a problem hiding this comment.
I think this has to be named I - non-private name.
| // This is a test package. | ||
| package interfaces | ||
|
|
||
| type Inter interface { |
| in, out := &in.Types, &out.Types | ||
| *out = make(map[string]*Ttest) | ||
| for key, val := range *in { | ||
| newVal, err := c.DeepCopy(&val) |
There was a problem hiding this comment.
Why do we expect this to hit the Cloner path?
Add new tests convering types related to changes made under kubernetes#46
|
LGTM! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new test convering servicecatalog types related to changes made under
#46