Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Create gcr.io/k8s-staging-publishing-bot #282

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Jun 15, 2019

This will house the publishing-bot image. For context, the publishing-bot runs on a CNCF cluster, moving the images also completely moves the publishing-bot to CNCF infra.

Currently, we use https://hub.docker.com/r/sttts/k8s-publishing-bot and @sttts needs to deploy each time we merge something.

Let me know if someone else should also be added to the google group.

/assign @dims @sttts

This will house the publishing-bot image. For context, the publishing-bot
runs on a CNCF cluster, moving the images also completely moves the
publishing-bot to CNCF infra.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 15, 2019
@k8s-ci-robot k8s-ci-robot requested review from dims and spiffxp June 15, 2019 07:11
@dims
Copy link
Member

dims commented Jun 17, 2019

/approve

/assign @justinsb @thockin

This creates a new GCR repo, Justin/Tim, can one of you please create it? @nikhita has updated the script.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2019
@sttts
Copy link
Contributor

sttts commented Jun 18, 2019

lgtm

@spiffxp
Copy link
Member

spiffxp commented Jun 19, 2019

/lgtm
/hold
do we need to wait for changes to be manually effected before merge, or do we merge this and then make the changes? /hold cancel when done or if this needs to merge before doing so

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 19, 2019
@nikhita
Copy link
Member Author

nikhita commented Jun 23, 2019

do we merge this and then make the changes

I guess this, but would prefer if someone who had the required access cancelled the hold on this, so that it isn't forgotten.

@thockin
Copy link
Member

thockin commented Jun 25, 2019

Well, the promoter isn't running yet, so the "prod" repo won't exist, but staging will.

Thanks!

/lgtm
/approve

@thockin thockin removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4de0e1f into kubernetes:master Jun 25, 2019
@thockin
Copy link
Member

thockin commented Jun 25, 2019

Actuating this now.

@thockin
Copy link
Member

thockin commented Jun 25, 2019

Someone needs to run the gsuite sync first. I have not enabled myself to that.

$ ./ensure-staging-storage.sh publishing-bot
publishing-bot
Ensuring project exists: k8s-staging-publishing-bot
Create in progress for [https://cloudresourcemanager.googleapis.com/v1/projects/k8s-staging-publishing-bot].
Waiting for [operations/cp.8482199488198082790] to finish...done.                                                                                             


Updates are available for some Cloud SDK components.  To install them,
please run:
  $ gcloud components update

Configuring billing for k8s-staging-publishing-bot
billingAccountName: billingAccounts/018801-93540E-22A20E
billingEnabled: true
name: projects/k8s-staging-publishing-bot/billingInfo
projectId: k8s-staging-publishing-bot
Enabling the container registry API
Operation "operations/acf.db991ce7-d590-49a9-9c88-940fcad13c48" finished successfully.
Ensuring the registry exists and is readable
Using default tag: latest
latest: Pulling from pause
Digest: sha256:a78c2d6208eff9b672de43f880093100050983047b7b0afe0217d3656e1b0d5f
Status: Image is up to date for k8s.gcr.io/pause:latest
The push refers to repository [gcr.io/k8s-staging-publishing-bot/ceci-nest-pas-une-image]
5f70bf18a086: Layer already exists 
e16a89738269: Pushed 
latest: digest: sha256:ec3ca3ee90e4dafde96c83232b30f17b5e8992ff35479d0661b8f4ff2f21bf74 size: 938
Digests:
- gcr.io/k8s-staging-publishing-bot/ceci-nest-pas-une-image@sha256:ec3ca3ee90e4dafde96c83232b30f17b5e8992ff35479d0661b8f4ff2f21bf74
  Associated tags:
 - latest
Tags:
- gcr.io/k8s-staging-publishing-bot/ceci-nest-pas-une-image:latest
Deleted [gcr.io/k8s-staging-publishing-bot/ceci-nest-pas-une-image:latest].
Deleted [gcr.io/k8s-staging-publishing-bot/ceci-nest-pas-une-image@sha256:ec3ca3ee90e4dafde96c83232b30f17b5e8992ff35479d0661b8f4ff2f21bf74].
Enabling Bucket Policy Only for gs://artifacts.k8s-staging-publishing-bot.appspot.com...
Empowering GCR admins
Updated IAM policy for project [k8s-staging-publishing-bot].
bindings:
- members:
  - serviceAccount:service-438481731081@containerregistry.iam.gserviceaccount.com
  role: roles/editor
- members:
  - user:thockin@google.com
  role: roles/owner
- members:
  - group:k8s-infra-artifact-admins@kubernetes.io
  role: roles/viewer
etag: BwWMHvBfmTw=
version: 1
Empowering k8s-infra-staging-publishing-bot@kubernetes.io to GCR
BadRequestException: 400 Group k8s-infra-staging-publishing-bot@kubernetes.io does not exist.

@nikhita nikhita deleted the k8s-staging-publishing-bot branch June 25, 2019 06:02
@nikhita
Copy link
Member Author

nikhita commented Jun 25, 2019

Someone needs to run the gsuite sync first.

Thanks @thockin! Afaik @dims and @cblecker have the required access to run the gsuite sync.

@cblecker
Copy link
Member

I'll do this in the morning

@thockin
Copy link
Member

thockin commented Jun 27, 2019 via email

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants