Create new infra-tools AR registry #7750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
area/infra
|
Ran Plan for dir: Show OutputNote: Objects have changed outside of Terraform
Terraform detected the following changes made outside of Terraform since the
last "terraform apply" which may have affected this plan:
# module.artifact_registry["charts"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
id = "projects/k8s-staging-images/locations/us-central1/repositories/charts"
name = "charts"
~ update_time = "2024-12-06T15:33:54.572945Z" -> "2025-02-03T16:30:11.067952Z"
# (10 unchanged attributes hidden)
# (1 unchanged block hidden)
}
# module.artifact_registry["cloud-provider-kind"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
id = "projects/k8s-staging-images/locations/us-central1/repositories/cloud-provider-kind"
name = "cloud-provider-kind"
~ update_time = "2024-11-25T21:04:11.526859Z" -> "2025-01-30T20:48:04.482588Z"
# (10 unchanged attributes hidden)
# (1 unchanged block hidden)
}
# module.artifact_registry["csi-vsphere"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
id = "projects/k8s-staging-images/locations/us-central1/repositories/csi-vsphere"
name = "csi-vsphere"
~ update_time = "2024-12-05T20:52:14.327242Z" -> "2025-01-30T20:39:50.828540Z"
# (10 unchanged attributes hidden)
# (1 unchanged block hidden)
}
# module.artifact_registry["etcd-manager"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
id = "projects/k8s-staging-images/locations/us-central1/repositories/etcd-manager"
name = "etcd-manager"
~ update_time = "2024-12-02T21:07:31.873341Z" -> "2025-01-26T14:42:21.387897Z"
# (10 unchanged attributes hidden)
# (1 unchanged block hidden)
}
# module.artifact_registry["kueue"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
id = "projects/k8s-staging-images/locations/us-central1/repositories/kueue"
name = "kueue"
~ update_time = "2024-12-06T15:32:42.661798Z" -> "2025-02-03T16:51:44.727619Z"
# (10 unchanged attributes hidden)
# (1 unchanged block hidden)
}
Unless you have made equivalent changes to your configuration, or ignored the
relevant attributes using ignore_changes, the following plan may include
actions to undo or respond to these changes.
─────────────────────────────────────────────────────────────────────────────
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
~ update in-place
- destroy
Terraform will perform the following actions:
# module.artifact_registry["gateway-api-inference-extension"].google_artifact_registry_repository.repo will be created
+ resource "google_artifact_registry_repository" "repo" {
+ cleanup_policy_dry_run = false
+ create_time = (known after apply)
+ effective_labels = {
+ "goog-terraform-provisioned" = "true"
}
+ format = "DOCKER"
+ id = (known after apply)
+ location = "us-central1"
+ mode = "STANDARD_REPOSITORY"
+ name = (known after apply)
+ project = "k8s-staging-images"
+ repository_id = "gateway-api-inference-extension"
+ terraform_labels = {
+ "goog-terraform-provisioned" = "true"
}
+ update_time = (known after apply)
+ cleanup_policies {
+ action = "DELETE"
+ id = "delete-images-older-than-90-days"
+ condition {
+ older_than = "7776000s"
+ package_name_prefixes = []
+ tag_prefixes = []
+ tag_state = "ANY"
+ version_name_prefixes = []
}
}
}
# module.artifact_registry["gateway-api-inference-extension"].google_artifact_registry_repository_iam_member.readers["allUsers"] will be created
+ resource "google_artifact_registry_repository_iam_member" "readers" {
+ etag = (known after apply)
+ id = (known after apply)
+ location = "us-central1"
+ member = "allUsers"
+ project = "k8s-staging-images"
+ repository = (known after apply)
+ role = "roles/artifactregistry.reader"
}
# module.artifact_registry["gateway-api-inference-extension"].google_artifact_registry_repository_iam_member.writers["group:sig-apps-leads@kubernetes.io"] will be created
+ resource "google_artifact_registry_repository_iam_member" "writers" {
+ etag = (known after apply)
+ id = (known after apply)
+ location = "us-central1"
+ member = "group:sig-apps-leads@kubernetes.io"
+ project = "k8s-staging-images"
+ repository = (known after apply)
+ role = "roles/artifactregistry.writer"
}
# module.artifact_registry["infra-tools"].google_artifact_registry_repository.repo will be created
+ resource "google_artifact_registry_repository" "repo" {
+ cleanup_policy_dry_run = false
+ create_time = (known after apply)
+ effective_labels = {
+ "goog-terraform-provisioned" = "true"
}
+ format = "DOCKER"
+ id = (known after apply)
+ location = "us-central1"
+ mode = "STANDARD_REPOSITORY"
+ name = (known after apply)
+ project = "k8s-staging-images"
+ repository_id = "infra-tools"
+ terraform_labels = {
+ "goog-terraform-provisioned" = "true"
}
+ update_time = (known after apply)
+ cleanup_policies {
+ action = "DELETE"
+ id = "delete-images-older-than-90-days"
+ condition {
+ older_than = "7776000s"
+ package_name_prefixes = []
+ tag_prefixes = []
+ tag_state = "ANY"
+ version_name_prefixes = []
}
}
}
# module.artifact_registry["infra-tools"].google_artifact_registry_repository_iam_member.readers["allUsers"] will be created
+ resource "google_artifact_registry_repository_iam_member" "readers" {
+ etag = (known after apply)
+ id = (known after apply)
+ location = "us-central1"
+ member = "allUsers"
+ project = "k8s-staging-images"
+ repository = (known after apply)
+ role = "roles/artifactregistry.reader"
}
# module.artifact_registry["infra-tools"].google_artifact_registry_repository_iam_member.writers["group:k8s-infra-staging-infra-tools@kubernetes.io"] will be created
+ resource "google_artifact_registry_repository_iam_member" "writers" {
+ etag = (known after apply)
+ id = (known after apply)
+ location = "us-central1"
+ member = "group:k8s-infra-staging-infra-tools@kubernetes.io"
+ project = "k8s-staging-images"
+ repository = (known after apply)
+ role = "roles/artifactregistry.writer"
}
# module.artifact_registry["llm-instance-gateway"].google_artifact_registry_repository.repo will be destroyed
# (because module.artifact_registry["llm-instance-gateway"] is not in configuration)
- resource "google_artifact_registry_repository" "repo" {
- cleanup_policy_dry_run = false -> null
- create_time = "2024-11-24T15:13:02.377922Z" -> null
- effective_labels = {} -> null
- format = "DOCKER" -> null
- id = "projects/k8s-staging-images/locations/us-central1/repositories/llm-instance-gateway" -> null
- labels = {} -> null
- location = "us-central1" -> null
- mode = "STANDARD_REPOSITORY" -> null
- name = "llm-instance-gateway" -> null
- project = "k8s-staging-images" -> null
- repository_id = "llm-instance-gateway" -> null
- terraform_labels = {} -> null
- update_time = "2025-02-03T18:07:47.093149Z" -> null
- cleanup_policies {
- action = "DELETE" -> null
- id = "delete-images-older-than-90-days" -> null
- condition {
- older_than = "7776000s" -> null
- package_name_prefixes = [] -> null
- tag_prefixes = [] -> null
- tag_state = "ANY" -> null
- version_name_prefixes = [] -> null
}
}
}
# module.artifact_registry["llm-instance-gateway"].google_artifact_registry_repository_iam_member.readers["allUsers"] will be destroyed
# (because module.artifact_registry["llm-instance-gateway"] is not in configuration)
- resource "google_artifact_registry_repository_iam_member" "readers" {
- etag = "BwYnqg30B5k=" -> null
- id = "projects/k8s-staging-images/locations/us-central1/repositories/llm-instance-gateway/roles/artifactregistry.reader/allUsers" -> null
- location = "us-central1" -> null
- member = "allUsers" -> null
- project = "k8s-staging-images" -> null
- repository = "projects/k8s-staging-images/locations/us-central1/repositories/llm-instance-gateway" -> null
- role = "roles/artifactregistry.reader" -> null
}
# module.artifact_registry["llm-instance-gateway"].google_artifact_registry_repository_iam_member.writers["group:sig-apps-leads@kubernetes.io"] will be destroyed
# (because module.artifact_registry["llm-instance-gateway"] is not in configuration)
- resource "google_artifact_registry_repository_iam_member" "writers" {
- etag = "BwYnqg30B5k=" -> null
- id = "projects/k8s-staging-images/locations/us-central1/repositories/llm-instance-gateway/roles/artifactregistry.writer/group:sig-apps-leads@kubernetes.io" -> null
- location = "us-central1" -> null
- member = "group:sig-apps-leads@kubernetes.io" -> null
- project = "k8s-staging-images" -> null
- repository = "projects/k8s-staging-images/locations/us-central1/repositories/llm-instance-gateway" -> null
- role = "roles/artifactregistry.writer" -> null
}
# module.iam.google_project_iam_binding.project_iam_authoritative["default--roles/viewer"] will be updated in-place
~ resource "google_project_iam_binding" "project_iam_authoritative" {
id = "k8s-staging-images/roles/viewer"
~ members = [
+ "group:k8s-infra-staging-infra-tools@kubernetes.io",
# (11 unchanged elements hidden)
]
# (3 unchanged attributes hidden)
}
Plan: 6 to add, 1 to change, 3 to destroy.
Note: Objects have changed outside of Terraform
|
|
atlantis apply |
|
Ran Apply for dir: Show Outputmodule.artifact_registry["llm-instance-gateway"].google_artifact_registry_repository_iam_member.writers["group:sig-apps-leads@kubernetes.io"]: Destroying... [id=projects/k8s-staging-images/locations/us-central1/repositories/llm-instance-gateway/roles/artifactregistry.writer/group:sig-apps-leads@kubernetes.io]
module.artifact_registry["llm-instance-gateway"].google_artifact_registry_repository_iam_member.readers["allUsers"]: Destroying... [id=projects/k8s-staging-images/locations/us-central1/repositories/llm-instance-gateway/roles/artifactregistry.reader/allUsers]
module.iam.google_project_iam_binding.project_iam_authoritative["default--roles/viewer"]: Modifying... [id=k8s-staging-images/roles/viewer]
module.artifact_registry["gateway-api-inference-extension"].google_artifact_registry_repository.repo: Creating...
module.artifact_registry["infra-tools"].google_artifact_registry_repository.repo: Creating...
module.iam.google_project_iam_binding.project_iam_authoritative["default--roles/viewer"]: Modifications complete after 7s [id=k8s-staging-images/roles/viewer]
module.artifact_registry["llm-instance-gateway"].google_artifact_registry_repository_iam_member.writers["group:sig-apps-leads@kubernetes.io"]: Destruction complete after 8s
module.artifact_registry["llm-instance-gateway"].google_artifact_registry_repository_iam_member.readers["allUsers"]: Destruction complete after 8s
module.artifact_registry["llm-instance-gateway"].google_artifact_registry_repository.repo: Destroying... [id=projects/k8s-staging-images/locations/us-central1/repositories/llm-instance-gateway]
module.artifact_registry["llm-instance-gateway"].google_artifact_registry_repository.repo: Destruction complete after 1s
module.artifact_registry["gateway-api-inference-extension"].google_artifact_registry_repository.repo: Still creating... [10s elapsed]
module.artifact_registry["infra-tools"].google_artifact_registry_repository.repo: Still creating... [10s elapsed]
module.artifact_registry["infra-tools"].google_artifact_registry_repository.repo: Creation complete after 10s [id=projects/k8s-staging-images/locations/us-central1/repositories/infra-tools]
module.artifact_registry["infra-tools"].google_artifact_registry_repository_iam_member.writers["group:k8s-infra-staging-infra-tools@kubernetes.io"]: Creating...
module.artifact_registry["infra-tools"].google_artifact_registry_repository_iam_member.readers["allUsers"]: Creating...
module.artifact_registry["gateway-api-inference-extension"].google_artifact_registry_repository.repo: Creation complete after 10s [id=projects/k8s-staging-images/locations/us-central1/repositories/gateway-api-inference-extension]
module.artifact_registry["gateway-api-inference-extension"].google_artifact_registry_repository_iam_member.writers["group:sig-apps-leads@kubernetes.io"]: Creating...
module.artifact_registry["gateway-api-inference-extension"].google_artifact_registry_repository_iam_member.readers["allUsers"]: Creating...
module.artifact_registry["infra-tools"].google_artifact_registry_repository_iam_member.writers["group:k8s-infra-staging-infra-tools@kubernetes.io"]: Creation complete after 8s [id=projects/k8s-staging-images/locations/us-central1/repositories/infra-tools/roles/artifactregistry.writer/group:k8s-infra-staging-infra-tools@kubernetes.io]
module.artifact_registry["infra-tools"].google_artifact_registry_repository_iam_member.readers["allUsers"]: Creation complete after 8s [id=projects/k8s-staging-images/locations/us-central1/repositories/infra-tools/roles/artifactregistry.reader/allUsers]
module.artifact_registry["gateway-api-inference-extension"].google_artifact_registry_repository_iam_member.writers["group:sig-apps-leads@kubernetes.io"]: Creation complete after 8s [id=projects/k8s-staging-images/locations/us-central1/repositories/gateway-api-inference-extension/roles/artifactregistry.writer/group:sig-apps-leads@kubernetes.io]
module.artifact_registry["gateway-api-inference-extension"].google_artifact_registry_repository_iam_member.readers["allUsers"]: Creation complete after 8s [id=projects/k8s-staging-images/locations/us-central1/repositories/gateway-api-inference-extension/roles/artifactregistry.reader/allUsers]
Apply complete! Resources: 6 added, 1 changed, 3 destroyed. |
|
/hold cancel infra has been applied |
|
Weird we got a destruction here: module.artifact_registry["llm-instance-gateway"].google_artifact_registry_repository.repo: Destroying... [id=projects/k8s-staging-images/locations/us-central1/repositories/llm-instance-gateway]
module.artifact_registry["llm-instance-gateway"].google_artifact_registry_repository.repo: Destruction complete after 1s? |
|
Its an unapplied plan from #7657 It got merged before it was applied. I need to get around to fixing the merge rules for atlantis |
upodroid
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Locks and plans deleted for the projects and workspaces modified in this pull request:
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3961
/hold for atlantis apply after lgtm