Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

openstack: Upgrade to Gophercloud v2 #16911

Merged
merged 1 commit into from
Oct 28, 2024
Merged

openstack: Upgrade to Gophercloud v2 #16911

merged 1 commit into from
Oct 28, 2024

Conversation

pierreprinetti
Copy link
Member

@pierreprinetti pierreprinetti commented Oct 22, 2024 •
edited
Loading

Gophercloud v1 is frozen and lacks a few improvements that can be found in the v2 branch. This patch bumps Gophercloud to the current v2 branch and makes the required modifications to the kops code.

Essentially:

  • Add a context argument to Gophercloud functions
  • Refactor scheduler hints for server creation

Incidentally, Gophercloud also got stricter in the accepted response codes. I have changed the mocked servers.Create call to return 202 instead of 201: docs

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 22, 2024
@k8s-ci-robot k8s-ci-robot added area/provider/openstack Issues or PRs related to openstack provider area/rolling-update labels Oct 22, 2024
@pierreprinetti pierreprinetti force-pushed the g2 branch 4 times, most recently from 69b16c4 to b883fc2 Compare October 22, 2024 14:25
@pierreprinetti pierreprinetti mentioned this pull request Oct 22, 2024
Merged
@pierreprinetti pierreprinetti force-pushed the g2 branch 2 times, most recently from 57ce944 to 0b0375d Compare October 22, 2024 16:47
@pierreprinetti
Copy link
Member Author

/retest

@pierreprinetti
Upgrade to Gophercloud v2
1005dda 
Essentially:

* Add a context argument to Gophercloud functions
* Refactor scheduler hints for server creation
@pierreprinetti
Copy link
Member Author

/retest

@pierreprinetti
Copy link
Member Author

/test e2e-scenarios-bare-metal

@k8s-ci-robot
Copy link
Contributor

@pierreprinetti: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test presubmit-kops-aws-boskos
  • /test presubmit-kops-aws-boskos-kubetest2
  • /test presubmit-kops-aws-scale-amazonvpc
  • /test presubmit-kops-aws-small-scale-amazonvpc-using-cl2
  • /test presubmit-kops-gce-scale-ipalias-using-cl2
  • /test presubmit-kops-gce-small-scale-ipalias-using-cl2
  • /test pull-kops-aws-distro-al2023
  • /test pull-kops-aws-distro-amazonlinux2
  • /test pull-kops-aws-distro-debian10
  • /test pull-kops-aws-distro-debian11
  • /test pull-kops-aws-distro-debian12
  • /test pull-kops-aws-distro-flatcar
  • /test pull-kops-aws-distro-rhel8
  • /test pull-kops-aws-distro-rhel9
  • /test pull-kops-aws-distro-rocky9
  • /test pull-kops-aws-distro-ubuntu2004
  • /test pull-kops-aws-distro-ubuntu2004arm64
  • /test pull-kops-aws-distro-ubuntu2204
  • /test pull-kops-aws-distro-ubuntu2204arm64
  • /test pull-kops-aws-distro-ubuntu2404
  • /test pull-kops-aws-distro-ubuntu2404arm64
  • /test pull-kops-build
  • /test pull-kops-e2e-arm64
  • /test pull-kops-e2e-aws-apiserver-nodes
  • /test pull-kops-e2e-aws-cloud-controller-manager
  • /test pull-kops-e2e-aws-dns-none
  • /test pull-kops-e2e-aws-external-dns
  • /test pull-kops-e2e-aws-ipv6-external-dns
  • /test pull-kops-e2e-aws-ipv6-karpenter
  • /test pull-kops-e2e-aws-ipv6-terraform
  • /test pull-kops-e2e-aws-karpenter
  • /test pull-kops-e2e-aws-load-balancer-controller
  • /test pull-kops-e2e-aws-nlb
  • /test pull-kops-e2e-aws-node-local-dns
  • /test pull-kops-e2e-aws-terraform
  • /test pull-kops-e2e-cni-amazonvpc
  • /test pull-kops-e2e-cni-calico
  • /test pull-kops-e2e-cni-canal
  • /test pull-kops-e2e-cni-cilium
  • /test pull-kops-e2e-cni-cilium-eni
  • /test pull-kops-e2e-cni-cilium-etcd
  • /test pull-kops-e2e-cni-flannel
  • /test pull-kops-e2e-k8s-aws-amazonvpc
  • /test pull-kops-e2e-k8s-aws-calico
  • /test pull-kops-e2e-k8s-ci
  • /test pull-kops-e2e-k8s-ci-ha
  • /test pull-kops-e2e-k8s-gce-calico-u2004-k22-containerd
  • /test pull-kops-e2e-k8s-gce-ci
  • /test pull-kops-e2e-k8s-gce-cilium
  • /test pull-kops-e2e-k8s-gce-cilium-etcd
  • /test pull-kops-e2e-k8s-gce-ipalias
  • /test pull-kops-e2e-k8s-gce-long-cluster-name
  • /test pull-kops-e2e-kubernetes-do-dns-none
  • /test pull-kops-e2e-kubernetes-do-fqdn
  • /test pull-kops-e2e-kubernetes-do-gossip
  • /test pull-kops-e2e-metrics-server
  • /test pull-kops-e2e-pod-identity-webhook
  • /test pull-kops-test
  • /test pull-kops-verify-boilerplate
  • /test pull-kops-verify-generated
  • /test pull-kops-verify-gofmt
  • /test pull-kops-verify-golangci-lint
  • /test pull-kops-verify-gomod
  • /test pull-kops-verify-govet
  • /test pull-kops-verify-hashes
  • /test pull-kops-verify-terraform

The following commands are available to trigger optional jobs:

  • /test presubmit-kops-aws-scale-amazonvpc-using-cl2
  • /test pull-kops-e2e-aws-upgrade-k129-ko129-to-k130-kolatest
  • /test pull-kops-e2e-aws-upgrade-k129-ko129-to-k130-kolatest-karpenter
  • /test pull-kops-e2e-aws-upgrade-k130-ko130-to-klatest-kolatest-many-addons
  • /test pull-kops-e2e-aws-upgrade-k130-kolatest-to-k131-kolatest
  • /test pull-kops-e2e-cni-amazonvpc-ipv6
  • /test pull-kops-e2e-cni-calico-ipv6
  • /test pull-kops-e2e-cni-cilium-ipv6
  • /test pull-kops-e2e-cni-kuberouter
  • /test pull-kops-e2e-gce-dns-none
  • /test pull-kops-kubernetes-e2e-cos-gce
  • /test pull-kops-kubernetes-e2e-cos-gce-serial
  • /test pull-kops-kubernetes-e2e-cos-gce-slow
  • /test pull-kops-kubernetes-e2e-ubuntu-gce-build

Use /test all to run the following jobs that were automatically triggered:

  • pull-kops-build
  • pull-kops-e2e-k8s-aws-amazonvpc
  • pull-kops-e2e-k8s-aws-calico
  • pull-kops-e2e-k8s-gce-cilium
  • pull-kops-e2e-k8s-gce-ipalias
  • pull-kops-kubernetes-e2e-ubuntu-gce-build
  • pull-kops-test
  • pull-kops-verify-boilerplate
  • pull-kops-verify-generated
  • pull-kops-verify-gofmt
  • pull-kops-verify-golangci-lint
  • pull-kops-verify-gomod
  • pull-kops-verify-govet

In response to this:

/test e2e-scenarios-bare-metal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pierreprinetti
Copy link
Member Author

Despite the huge LOC change count, this patch should be relatively straightforward, as it’s almost exclusively the same regex applied all over. Let me know if I can help with the review @zetaab @olemarkus.

@hakman
Copy link
Member

hakman commented Oct 25, 2024

Despite the huge LOC change count, this patch should be relatively straightforward, as it’s almost exclusively the same regex applied all over. Let me know if I can help with the review @zetaab @olemarkus.

Thank you @pierreprinetti, the review seems pretty straightforward.
I will wait for @zetaab's final approval, as we don't have any e2e tests for OpenStack.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2024
@hakman
Copy link
Member

hakman commented Oct 25, 2024

/assign @zetaab

@olemarkus
Copy link
Member

/lgtm

@hakman hakman changed the title Upgrade to Gophercloud v2 openstack: Upgrade to Gophercloud v2 Oct 25, 2024
zetaab
zetaab approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2024
@k8s-ci-robot k8s-ci-robot merged commit d355404 into kubernetes:master Oct 28, 2024
25 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Oct 28, 2024
@pierreprinetti pierreprinetti deleted the g2 branch October 28, 2024 13:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@zetaab zetaab zetaab approved these changes

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@olemarkus olemarkus

@hakman hakman

@zetaab zetaab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/openstack Issues or PRs related to openstack provider area/rolling-update cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
5 participants
@pierreprinetti @k8s-ci-robot @hakman @olemarkus @zetaab