-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add support for configuring environment variables on kube-apiserver #16920
Conversation
Hi @rsafonseca. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kops-e2e-k8s-gce-cilium |
This PR allows configuring environment variables for the kube-apiserver.
This presents high value in order to be able to control a number of runtime settings, such as the ones in the code examples.
main motivation:
The apiserver is a memory hungry beast, and currently we have no way of controlling garbage collection settings, which can easily lead to OOM, or the need to run on much larger instances to prevent that, making the kops control plane very costly.
future proofing:
This provides the flexibility to add any other unforeseen variables that could be useful for the kops cluster admin