-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(docs): add toggle for light/dark mode support #16951
feat(docs): add toggle for light/dark mode support #16951
Conversation
Very cool! Looking at the docs I see we can add a media selector to default to the operating system's light/dark preference: https://squidfunk.github.io/mkdocs-material/setup/changing-the-colors/#automatic-light-dark-mode Any chance you can add that here as well? |
Sure thing! UPDATE: DONE! |
8913393
to
2b1d197
Compare
/retest |
1 similar comment
/retest |
Thanks @moshevayner! :smiling |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This adds a long-overdue toggle for dark mode support in our docs website. The website will automatically align with the OS theme (light/dark), but it's possible to toggle dark mode on/off by using the switch.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Special notes for your reviewer:
Followed mkdocs insturctions here
Netlify Preview deploy here
And also screenshots below.
Light Mode Screenshot (Same as before):
Dark Mode Screenshot: