Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor: build assets for kubernetes and nodeup explicitly #16954

Merged
merged 1 commit into from
Nov 27, 2024
Merged

refactor: build assets for kubernetes and nodeup explicitly #16954

merged 1 commit into from
Nov 27, 2024

Conversation

justinsb
Copy link
Member

Also remove the (potentially) confusing FileAssets type.

@justinsb
refactor: build assets for kubernetes and nodeup explicitly
49de7d6 
Also remove the (potentially) confusing FileAssets type.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 24, 2024
@justinsb
Copy link
Member Author

/retest

@justinsb justinsb mentioned this pull request Nov 27, 2024
Merged
@justinsb
Copy link
Member Author

I think if we can get this PR in, then this will greatly simplify #16932. I then have a few more small cleanup PRs and then we are able to update the cluster safely according to the version skew policy :-)

cc @hakman

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit 59e06d8 into kubernetes:master Nov 27, 2024
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Nov 27, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hakman hakman hakman approved these changes

@olemarkus olemarkus Awaiting requested review from olemarkus

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
3 participants
@justinsb @k8s-ci-robot @hakman