Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: create abstraction over cluster/instancegroup for building assets #16955

Merged

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Nov 25, 2024

This abstraction should let us change the version on an instance group level.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 25, 2024
@justinsb justinsb force-pushed the refactor_kubernetes_version branch from c1276c0 to a839e3b Compare November 25, 2024 13:47
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 27, 2024
@justinsb justinsb force-pushed the refactor_kubernetes_version branch from a839e3b to c79457e Compare November 27, 2024 12:34
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 27, 2024
@justinsb justinsb changed the title WIP: refactor: create abstraction over cluster/instancegroup for building assets refactor: create abstraction over cluster/instancegroup for building assets Nov 27, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 27, 2024
@justinsb justinsb force-pushed the refactor_kubernetes_version branch from c79457e to 9448e5b Compare November 27, 2024 12:38
…assets

This abstraction should let us change the version on an instance group level.
@justinsb justinsb force-pushed the refactor_kubernetes_version branch from 9448e5b to 3f38846 Compare November 27, 2024 12:38
@justinsb
Copy link
Member Author

I think we need this one also, it introduces the idea that the kubernetes version is a property of the instance group, without needing to fully wire up the field.

cc @hakman

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2024
@hakman
Copy link
Member

hakman commented Nov 27, 2024

/override pull-kops-e2e-cni-cilium-eni
/override pull-kops-e2e-cni-cilium-etcd

@k8s-ci-robot
Copy link
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-cni-cilium-eni, pull-kops-e2e-cni-cilium-etcd

In response to this:

/override pull-kops-e2e-cni-cilium-eni
/override pull-kops-e2e-cni-cilium-etcd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit cfb6ef2 into kubernetes:master Nov 27, 2024
27 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Nov 27, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants