-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
refactor: create abstraction over cluster/instancegroup for building assets #16955
refactor: create abstraction over cluster/instancegroup for building assets #16955
Conversation
c1276c0
to
a839e3b
Compare
a839e3b
to
c79457e
Compare
c79457e
to
9448e5b
Compare
…assets This abstraction should let us change the version on an instance group level.
9448e5b
to
3f38846
Compare
I think we need this one also, it introduces the idea that the kubernetes version is a property of the instance group, without needing to fully wire up the field. cc @hakman |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override pull-kops-e2e-cni-cilium-eni |
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-cni-cilium-eni, pull-kops-e2e-cni-cilium-etcd In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This abstraction should let us change the version on an instance group level.