Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Dial down warning level when asset is not found #16985

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Dial down warning level when asset is not found #16985

merged 1 commit into from
Dec 7, 2024

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Dec 6, 2024

We have to download the hash file for assets that are not well-known,
but this is not an error, and this causes a lot of noise in our logs.

@justinsb
Dial down warning level when asset is not found
c5b1834 
We have to download the hash file for assets that are not well-known,
but this is not an error, and this causes a lot of noise in our logs.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 6, 2024
@justinsb
Copy link
Member Author

justinsb commented Dec 6, 2024

cc @hakman I think you said this was confusing to users? We could also skip the warning only if the URL matches KOPS_BASE_URL, meaning we would still be alerted when we have not updated the hashes in a while!

hakman
hakman reviewed Dec 6, 2024
View reviewed changes
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 😀

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2024
@hakman
Copy link
Member

hakman commented Dec 6, 2024

/retest

@hakman
Copy link
Member

hakman commented Dec 6, 2024

/override pull-kops-e2e-k8s-aws-amazonvpc

@k8s-ci-robot
Copy link
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-aws-amazonvpc

In response to this:

/override pull-kops-e2e-k8s-aws-amazonvpc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 951129c into kubernetes:master Dec 7, 2024
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Dec 7, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hakman hakman hakman approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
3 participants
@justinsb @k8s-ci-robot @hakman