Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

v2: Remove deprecated metrics #1004

Merged
merged 1 commit into from
Feb 5, 2020
Merged

v2: Remove deprecated metrics #1004

merged 1 commit into from
Feb 5, 2020

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Dec 13, 2019

Signed-off-by: yeya24 yb532204897@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #974

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 13, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @yeya24!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 13, 2019
@k8s-ci-robot k8s-ci-robot requested review from lilic and zouyee December 13, 2019 17:22
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 14, 2019
lilic
lilic reviewed Dec 16, 2019
View reviewed changes
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/hold
until the next release

docs/cli-arguments.md
@@ -25,35 +25,33 @@ spec:
```txt
$ kube-state-metrics -h
Usage of ./kube-state-metrics:
--add_dir_header If true, adds the file directory to the header
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides from here, we also need to remove them from the docs. https://github.com/kubernetes/kube-state-metrics/blob/f09db29f7955e5e628c54130fac1ac116836412c/docs/node-metrics.md

That should fix the CI.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2019
@yeya24
Copy link
Contributor Author

yeya24 commented Dec 16, 2019

@lilic Hi, do I also need to remove this part?
https://github.com/kubernetes/kube-state-metrics/blob/master/docs/README.md#metrics-deprecation

@yeya24 yeya24 force-pushed the remove-deprecated-metrics branch from 04d0234 to b4f5692 Compare December 16, 2019 15:10
@lilic
Copy link
Member

lilic commented Dec 16, 2019

@yeya24 yes, lets remove that as well. 👍 Thanks!

@tariq1890 tariq1890 changed the title Remove deprecated metrics v2: Remove deprecated metrics Dec 17, 2019
@tariq1890 tariq1890 added the v2 version 2 label Dec 17, 2019
@lilic
Copy link
Member

lilic commented Jan 31, 2020

@yeya24 do you mind rebasing your PR, after that we can merge, thanks! :)

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2020
@yeya24 yeya24 force-pushed the remove-deprecated-metrics branch from 0b4ca08 to 72649e8 Compare January 31, 2020 13:37
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 31, 2020
@yeya24
Copy link
Contributor Author

yeya24 commented Feb 3, 2020

@lilic HI, could you please take a look at this? CI passed.

lilic
lilic approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 3, 2020
@yeya24
remove deprecated metrics
da2dadc 
Signed-off-by: yeya24 <yb532204897@gmail.com>

remove deprecated options

Signed-off-by: yeya24 <yb532204897@gmail.com>
@yeya24 yeya24 force-pushed the remove-deprecated-metrics branch from 714613b to da2dadc Compare February 5, 2020 13:48
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2020
@yeya24
Copy link
Contributor Author

yeya24 commented Feb 5, 2020

@lilic Hello,
I have rebased my PR again, is it okay to be merged now?

@lilic
Copy link
Member

lilic commented Feb 5, 2020

/hold cancel

Thanks! :)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2020
@lilic
Copy link
Member

lilic commented Feb 5, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiliC, yeya24

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f8bcc02 into kubernetes:master Feb 5, 2020
@jimmyseto jimmyseto mentioned this pull request Oct 6, 2020
Closed
@mcavoyk mcavoyk mentioned this pull request Oct 14, 2020
Closed
@yosshi825 yosshi825 mentioned this pull request Oct 19, 2020
Closed
@krithika369 krithika369 mentioned this pull request Jun 10, 2022
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lilic lilic lilic approved these changes

@zouyee zouyee Awaiting requested review from zouyee

Assignees

@lilic lilic

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. v2 version 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v2: Remove deprecated metrics
4 participants
@yeya24 @k8s-ci-robot @lilic @tariq1890