Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add security context to deployment and statefulset #1034

Merged
merged 2 commits into from
Jan 22, 2020
Merged

Add security context to deployment and statefulset #1034

merged 2 commits into from
Jan 22, 2020

Conversation

olegmayko
Copy link
Contributor

What this PR does / why we need it:
to improve deployment to k8s clusters with enabled PSP.
Which issue(s) this PR fixes * fixes #1031

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 22, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @olegmayko!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2020
@brancz
Copy link
Member

brancz commented Jan 22, 2020

This needs a re-generate of the example manifests. Just run make examples.

@olegmayko
Copy link
Contributor Author

ups. done.

@brancz
Copy link
Member

brancz commented Jan 22, 2020

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, olegmayko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit d6677ac into kubernetes:master Jan 22, 2020
@olegmayko olegmayko mentioned this pull request Jan 22, 2020
Closed
niedbalski pushed a commit to niedbalski/cdk-addons that referenced this pull request Dec 1, 2020
@bilboer
[kube-state-metrics] add security context
753914b 
Fixes LP: #1906303, by patching the deployment manifest
of kube-state-metrics according to upstream patch
kubernetes/kube-state-metrics#1034

Signed-off-by: Jorge Niedbalski <jorge.niedbalski@canonical.com>
@niedbalski niedbalski mentioned this pull request Dec 1, 2020
Merged
niedbalski pushed a commit to niedbalski/cdk-addons that referenced this pull request Dec 1, 2020
@bilboer
[kube-state-metrics] add security context
a396b9a 
Fixes LP: #1906303, by patching the deployment manifest
of kube-state-metrics according to upstream patch
kubernetes/kube-state-metrics#1034

Signed-off-by: Jorge Niedbalski <jorge.niedbalski@canonical.com>
niedbalski pushed a commit to niedbalski/cdk-addons that referenced this pull request Dec 1, 2020
@bilboer
[kube-state-metrics] add security context
6588615 
Fixes LP: #1906303, by patching the deployment manifest
of kube-state-metrics according to upstream patch
kubernetes/kube-state-metrics#1034

Signed-off-by: Jorge Niedbalski <jorge.niedbalski@canonical.com>
Cynerva pushed a commit to charmed-kubernetes/cdk-addons that referenced this pull request Dec 15, 2020
@niedbalski
[kube-state-metrics] add security context (#200)
bace960 
Fixes LP: #1906303, by patching the deployment manifest
of kube-state-metrics according to upstream patch
kubernetes/kube-state-metrics#1034

Signed-off-by: Jorge Niedbalski <jorge.niedbalski@canonical.com>
Cynerva pushed a commit to charmed-kubernetes/cdk-addons that referenced this pull request Feb 19, 2021
@niedbalski
[kube-state-metrics] add security context (#200)
c2f0671 
Fixes LP: #1906303, by patching the deployment manifest
of kube-state-metrics according to upstream patch
kubernetes/kube-state-metrics#1034

Signed-off-by: Jorge Niedbalski <jorge.niedbalski@canonical.com>
Cynerva pushed a commit to charmed-kubernetes/cdk-addons that referenced this pull request Feb 19, 2021
@niedbalski
[kube-state-metrics] add security context (#200)
c39e188 
Fixes LP: #1906303, by patching the deployment manifest
of kube-state-metrics according to upstream patch
kubernetes/kube-state-metrics#1034

Signed-off-by: Jorge Niedbalski <jorge.niedbalski@canonical.com>
Cynerva pushed a commit to charmed-kubernetes/cdk-addons that referenced this pull request Feb 19, 2021
@niedbalski
[kube-state-metrics] add security context (#200)
657d665 
Fixes LP: #1906303, by patching the deployment manifest
of kube-state-metrics according to upstream patch
kubernetes/kube-state-metrics#1034

Signed-off-by: Jorge Niedbalski <jorge.niedbalski@canonical.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@andyxning andyxning Awaiting requested review from andyxning

@tariq1890 tariq1890 Awaiting requested review from tariq1890

Assignees

@brancz brancz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olegmayko @k8s-ci-robot @brancz