Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update go module path to k8s.io/kube-state-metrics/v2 #1238

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Update go module path to k8s.io/kube-state-metrics/v2 #1238

merged 1 commit into from
Sep 23, 2020

Conversation

QuentinBisson
Copy link
Contributor

Signed-off-by: Quentin Bisson quentin@giantswarm.io

What this PR does / why we need it:

Updating go module path to v2 towards #569

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 21, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @omegas27!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 21, 2020
@QuentinBisson
Update go module path to k8s.io/kube-state-metrics/v2
7250bc2 
Signed-off-by: Quentin Bisson <quentin@giantswarm.io>
@QuentinBisson QuentinBisson marked this pull request as ready for review September 21, 2020 08:58
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2020
lilic
lilic reviewed Sep 21, 2020
View reviewed changes
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, have one question!

cc @brancz @tariq1890 PTAL

go.mod

require (
github.com/Azure/go-autorest/autorest v0.10.0 // indirect
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious of all the changes that were added?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just triggered go mod tidy but maybe I should have done it in a different way?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a problem at all, mainly asking as we will be porting this to release 2.0 branch and did not want to introduce any new not needed changes, but don't think its a problem here.

@brancz
Copy link
Member

brancz commented Sep 23, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, omegas27

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit 392f924 into kubernetes:master Sep 23, 2020
@stone-z stone-z mentioned this pull request Dec 4, 2020
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lilic lilic lilic left review comments

@brancz brancz Awaiting requested review from brancz

@tariq1890 tariq1890 Awaiting requested review from tariq1890

Assignees

@brancz brancz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@QuentinBisson @k8s-ci-robot @brancz @lilic