-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: add kube_secret_owner metric #2298
Conversation
|
Welcome @jrcichra! |
c1a32c3
to
80eb33b
Compare
/triage accepted |
Needs CLA. |
CLA signed. Thanks! |
Are there any other prerequisites I need to complete? |
@rexagod I've completed all the prerequisites and all the tests are passing. Please review at your earliest convenience. :) |
Add the kube_secret_owner metric for Secrets. This metric already exists for several other Kubernetes primitives (Jobs, Pods, etc). Cluster operators will often use external secret stores with a controller to reconcile those secrets into Kubernetes Secrets. Cluster operators may wish to discourage manually managed secrets. Having the secret owner data in kube-state-metrics allows graphing and alerting on unmanaged secrets.
80eb33b
to
01507af
Compare
@CatherineF-dev thanks for the review, would you mind taking another look? |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jrcichra, mrueg, rexagod The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Add the kube_secret_owner metric for Secrets.
This metric already exists for several other Kubernetes primitives (Jobs, Pods, etc).
Cluster operators will often use external secret stores with a controller to reconcile those secrets into Kubernetes Secrets.
Cluster operators may wish to discourage manually managed secrets.
Having the secret owner data in kube-state-metrics allows graphing and alerting on unmanaged secrets.
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Increases by adding an additional metric for each Secret in the cluster.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Relates To: #1993