-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore: Fix the security issue about sirupsen/logrus #2509
Conversation
The committers listed above are authorized under a signed CLA. |
This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Welcome @kevinwangcn! |
Can you use |
0b80cf2
to
82e0b1e
Compare
Updated my PR. thanks for the review. |
82e0b1e
to
058ed61
Compare
Is there a CVE for this vulnerability? Does golvulncheck validate that the affected symbols are actually being used in the codebase? |
058ed61
to
9e1bbb4
Compare
yes, this is going to solve a CVE issue. Attached is the scan report via Twistlock. Please refer to it for more details. |
9e1bbb4
to
ba9eb94
Compare
@rexagod @CatherineF-dev Could you please review my PR? Thanks a lot. |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CatherineF-dev, kevinwangcn, mrueg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There is a security concern using the
github.com/sirupsen/logrus
with version1.8.1
Supporting Material/References:
sirupsen/logrus#1370
Impact
This happens if you try to log something that is longer than 64kb without newlines through something like cmd.Stdout = logrus.Writer().
This can cause a denial of service in some cases.
What this PR does / why we need it:
The PR is going to bump up the version for this particular module from
1.8.1
to1.9.3
which has resolved the security issue.How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #