-
Notifications
You must be signed in to change notification settings - Fork 40.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Drop dead beta storage and validation code #104248
Conversation
/priority important-soon |
/hold for reviews |
/milestone v1.23 |
Dropped definitions for alpha types which are no longer served
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Now that's a cathartic PR. /lgtm |
This is great, thanks @liggitt! Networking commit LGTM. |
/lgtm |
/hold cancel |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
Why https://github.com/kubernetes/kubernetes/tree/master/pkg/apis/rbac/v1alpha1 is still there and https://github.com/kubernetes/kubernetes/tree/master/pkg/apis/scheduling/v1alpha1 is still there if both APIs are dropped? |
All code related to serving those versions was removed, but the types and conversions still exist to support reading/converting data stored in etcd in those versions |
So ... those schemes are still installed, just for conversions convenience? |
they're installed so that pre-release data exists in etcd, it can still be read/converted in order to be served as v1 objects in response to a v1 API request |
@liggitt Thanks for the clarification. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Drops the storage and validation code that was only exercised by the beta versions no longer served since 1.22.
Does this PR introduce a user-facing change?
/assign @deads2k