Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Bump cAdvisor to v0.50.0 #126361

Closed
wants to merge 1 commit into from
Closed

Bump cAdvisor to v0.50.0 #126361

wants to merge 1 commit into from

Conversation

cwangVT
Copy link

@cwangVT cwangVT commented Jul 25, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Bump to the latest cAdvisor release v0.50

Changelog - google/cadvisor@v0.49.0...v0.50.0

Release notes - https://github.com/google/cadvisor/releases/tag/v0.50.0

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Bump cAdvisor to v0.50.0

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 25, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

Welcome @cwangVT!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 25, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @cwangVT. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jul 25, 2024
@k8s-ci-robot k8s-ci-robot requested review from alexzielenski, aojea and a team July 25, 2024 18:47
@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kube-proxy area/kubectl area/kubelet sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 25, 2024
@dims dims mentioned this pull request Aug 14, 2024
Merged
@kiashok kiashok mentioned this pull request Aug 16, 2024
Open
@cwangVT cwangVT closed this Aug 17, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 17, 2024
@cwangVT cwangVT reopened this Aug 17, 2024
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cwangVT
Once this PR has been reviewed and has the lgtm label, please assign andrewsykim, deads2k, dims, jsafrane, neolit123, seans3, sttts for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels Aug 17, 2024
@cwangVT
Copy link
Author

cwangVT commented Aug 17, 2024

/hold

Will wait for microsoft/hcsshim#2236

@kiashok
Copy link
Contributor

kiashok commented Aug 20, 2024

ok... so... we're in gridlock...

  1. cadvisor started referencing the carved out github.com/containerd/containerd/api module in v0.50.0

  2. that means that we either have to eliminate github.com/containerd/containerd from our graph completely or update to a version new enough that it excludes the carved out github.com/containerd/containerd/api

    • Updating to a containerd version that carves out the API submodule (v1.7.19+ - https://github.com/containerd/containerd/blob/v1.7.19/go.mod#L15) isn't doable because it also adds dependencies on k8s.io staging libraries - https://github.com/containerd/containerd/blob/v1.7.19/go.mod#L79-L84

    • I think eliminating github.com/containerd/containerd from our graph completely means dropping it from github.com/Microsoft/hcsshim:

      go mod graph | grep " github.com/containerd/containerd@"
github.com/Microsoft/hcsshim@v0.8.26 github.com/containerd/containerd@v1.4.9

      which does not seem feasible (hcsshim uses containerd in almost 100 places):

      hcsshim$ git grep "github.com/containerd/containerd" | grep \.go | grep -v vendor | wc -l
98

      or dropping our use of github.com/Microsoft/hcsshim (used in 4 files in k/k, I don't know how feasible this is)

  • We can't update github.com/containerd/containerd past v1.4.x (so a 2-year-old version) because v1.5.0+ adds a go.mod which surfaces the loopback dependency on k8s.io staging libraries
  • We can't update github.com/microsoft/hcsshim past v0.8.26 (so a 3-year-old version) because v0.9.0+ pulls in containerd/containerd v1.5.x+
  • We can't update cadvisor to v0.50.0 because it depends on the carved out containerd/containerd/api module which is ambiguous about which containerd module provides that package until we update containerd/containerd to v1.7.19+ (which we can't do) or eliminate containerd/containerd entirely

Sent a PR out with updated hcsshim tag: #126799

@liggitt liggitt mentioned this pull request Aug 22, 2024
Merged
@logicalhan
Copy link
Member

/remove-sig instrumentation

@k8s-ci-robot k8s-ci-robot removed the sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. label Aug 22, 2024
@fedebongio
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Aug 22, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dims
Copy link
Member

dims commented Sep 5, 2024

/close

please see #126799

@k8s-ci-robot
Copy link
Contributor

@dims: Closed this PR.

In response to this:

/close

please see #126799

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@alexzielenski alexzielenski Awaiting requested review from alexzielenski

@aojea aojea Awaiting requested review from aojea

Assignees
No one assigned
Labels
area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kube-proxy area/kubectl area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
SIG Auth
Status: Closed / Done
SIG CLI
Status: Closed
SIG Node PR Triage
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.