Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove generally available feature gate HPAContainerMetrics #126862

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Remove generally available feature gate HPAContainerMetrics #126862

merged 1 commit into from
Nov 5, 2024

Conversation

carlory
Copy link
Member

@carlory carlory commented Aug 22, 2024 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

HPAContainerMetrics GA: v1.30

A follow-up of #123482

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Removed generally available feature gate `HPAContainerMetrics`

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 22, 2024
@carlory
Copy link
Member Author

carlory commented Aug 22, 2024

/cc @sanposhiho

@k8s-ci-robot k8s-ci-robot requested review from dchen1107 and dims August 22, 2024 03:23
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 22, 2024
@carlory
Copy link
Member Author

carlory commented Aug 22, 2024

/sig autoscaling
/sig apps

@k8s-ci-robot k8s-ci-robot added sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Aug 22, 2024
sanposhiho
sanposhiho approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/cc @gjtempleton

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 91cd93a274511a0fad895c1d9cf88fb22d318077

@carlory carlory mentioned this pull request Aug 22, 2024
Merged
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@carlory
Copy link
Member Author

carlory commented Aug 22, 2024

/assign @deads2k

@carlory
Copy link
Member Author

carlory commented Aug 22, 2024

/test pull-kubernetes-integration

@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Aug 22, 2024
@carlory
Copy link
Member Author

carlory commented Sep 27, 2024

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 1, 2024
@carlory carlory force-pushed the HPAContainerMetrics branch from 3cb12eb to eaeacb3 Compare October 8, 2024 02:06
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 8, 2024
@carlory
Copy link
Member Author

carlory commented Oct 10, 2024

/cc @deads2k @gjtempleton

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2024
@carlory carlory force-pushed the HPAContainerMetrics branch from eaeacb3 to d62ee4a Compare October 18, 2024 06:38
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2024
@carlory
Copy link
Member Author

carlory commented Oct 18, 2024

/test pull-kubernetes-e2e-gce

@carlory
Copy link
Member Author

carlory commented Nov 5, 2024

/cc @liggitt

Could you take a look if you have time?

It was approved by @sanposhiho but is removed due to rebasing uptream code.

@k8s-ci-robot k8s-ci-robot requested a review from liggitt November 5, 2024 06:27
@liggitt
Copy link
Member

liggitt commented Nov 5, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d1ebddbe334b948f1b3d80d71f855b5d49283888

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, liggitt, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2024
@k8s-ci-robot
Copy link
Contributor

@carlory: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-gce d62ee4a link unknown /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@carlory
Copy link
Member Author

carlory commented Nov 5, 2024

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot merged commit f56db61 into kubernetes:master Nov 5, 2024
15 of 16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Nov 5, 2024
@carlory carlory deleted the HPAContainerMetrics branch November 5, 2024 16:20
This was referenced Nov 5, 2024
Merged
Merged
@tengqm
Copy link
Contributor

tengqm commented Nov 6, 2024

Please do propose a change to the website for this removal.

@carlory
Copy link
Member Author

carlory commented Nov 6, 2024

cc @tengqm kubernetes/website#47625

@frezbo frezbo mentioned this pull request Nov 7, 2024
Merged
This was referenced Nov 9, 2024
Closed
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@dims dims Awaiting requested review from dims

@gjtempleton gjtempleton Awaiting requested review from gjtempleton

@deads2k deads2k Awaiting requested review from deads2k

@sanposhiho sanposhiho Awaiting requested review from sanposhiho

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

@deads2k deads2k

@sanposhiho sanposhiho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Apps
Archived in project
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
8 participants
@carlory @k8s-ci-robot @k8s-triage-robot @fedebongio @liggitt @tengqm @sanposhiho @deads2k