Add support for limiting grace period during soft eviction #25772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekwaynecarr
force-pushed
the
eviction-max-grace
branch
from
ce12f77 to
dec494b
Compare
derekwaynecarr
added
the
release-note
k8s-github-robot
added
the
size/M
| @@ -44,6 +44,8 @@ const ( | |||
| type Config struct { | |||
| // PressureTransitionPeriod is duration the kubelet has to wait before transititioning out of a pressure condition. | |||
| PressureTransitionPeriod time.Duration | |||
| // Maximum allowed grace period (in seconds) to use when terminating pods in response to a soft eviction threshold being met. | |||
| MaxPodGracePeriod int64 | |||
There was a problem hiding this comment.
nit: Add Seconds suffix to the field.
|
Just one nit. Otherwise LGTM |
derekwaynecarr
force-pushed
the
eviction-max-grace
branch
from
dec494b to
da35b9a
Compare
|
@vishh nit addressed. |
vishh
added
the
lgtm
derekwaynecarr
force-pushed
the
eviction-max-grace
branch
from
da35b9a to
1a9071e
Compare
k8s-github-robot
removed
the
lgtm
derekwaynecarr
added
the
lgtm
derekwaynecarr
force-pushed
the
eviction-max-grace
branch
from
1a9071e to
2a1d3fa
Compare
k8s-github-robot
removed
the
lgtm
derekwaynecarr
added
the
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 2a1d3fa. |
|
Automatic merge from submit-queue |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds eviction manager support in kubelet for max pod graceful termination period when a soft eviction is met.
/cc @vishh