Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

GCI/Trusty: support the Docker registry mirror #26745

Merged
merged 1 commit into from
Jun 3, 2016
Merged

GCI/Trusty: support the Docker registry mirror #26745

merged 1 commit into from
Jun 3, 2016

Conversation

andyzheng0831
Copy link

@roberthbailey @zmerlynn please review it.

cc/ @fabioy @dchen1107 @kubernetes/goog-image FYI.

cc/ @ojarjur it is very straightforward to add support for GCI, which is pretty much like the change to ContainerVM's configure-vm.sh in your original PR #25841.

@andyzheng0831 andyzheng0831 added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/os/gci labels Jun 2, 2016
@andyzheng0831 andyzheng0831 added this to the v1.3 milestone Jun 2, 2016
@ojarjur
Copy link
Contributor

ojarjur commented Jun 2, 2016

Looks good to me.

@roberthbailey roberthbailey added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2016
@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 2, 2016
@k8s-bot
Copy link

k8s-bot commented Jun 2, 2016

GCE e2e build/test passed for commit 530bd5f.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jun 3, 2016

GCE e2e build/test passed for commit 530bd5f.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 8d57a44 into kubernetes:master Jun 3, 2016
@andyzheng0831 andyzheng0831 deleted the docker-reg branch June 3, 2016 16:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants