Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Bump GCI version to gci-dev-56-8977-0-0 #36681

Merged
merged 1 commit into from
Nov 12, 2016
Merged

Bump GCI version to gci-dev-56-8977-0-0 #36681

merged 1 commit into from
Nov 12, 2016

Conversation

mtaufen
Copy link
Contributor

@mtaufen mtaufen commented Nov 11, 2016 •
edited
Loading

@vishh @saad

gci-dev-56-8977-0-0:
Date:           Nov 03, 2016
Kernel:         ChromiumOS-4.4
Kubernetes:     v1.4.5
Docker:         v1.11.2
Changelog (vs 55-8872-18-0)
    * Updated kubernetes to v1.4.5
    * Fixed a bug in e2fsprogs that caused mke2fs to take a very long time. Upstream fix: http://git.kernel.org/cgit/fs/ext2/e2fsprogs.git/commit/?h=next&id=d33e690fe7a6cbeb51349d9f2c7fb16a6ebec9c2

This change is Reviewable

@mtaufen mtaufen added area/os/gci priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Nov 11, 2016
@mtaufen mtaufen force-pushed the 1.5-gci-dev-56-8977-0-0 branch from 666dde8 to a38c613 Compare November 12, 2016 00:00
@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 12, 2016
@vishh
Copy link
Contributor

vishh commented Nov 12, 2016

Include the changelog in the release note.

@vishh vishh added this to the v1.5 milestone Nov 12, 2016
vishh
vishh reviewed Nov 12, 2016
View reviewed changes
test/e2e_node/jenkins/cri_validation/benchmark-config.yaml
@@ -1,56 +1,56 @@
---
images:
gci-density1:
image: gci-dev-55-8872-18-0
image: gci-dev-56-8977-0-0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we should may be make these tests derive from a common subsection to avoid updating the image name so many times. Not necessary for this PR though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. It looks like @Random-Liu made some progress towards this sort of goal for some other config files in 3922dd6, maybe he can do the same for these.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared to gci-dev-55-8872-18-0, the change-log also includes several other things:

@vishh
Copy link
Contributor

vishh commented Nov 12, 2016

LGTM

@vishh vishh added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit a38c613. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit a38c613. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@mtaufen
Copy link
Contributor Author

mtaufen commented Nov 12, 2016

@k8s-bot gci gke e2e test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 800ef09 into kubernetes:master Nov 12, 2016
@jingxu97 jingxu97 mentioned this pull request Nov 16, 2016
Closed
@yujuhong yujuhong mentioned this pull request Nov 16, 2016
Merged
@jingxu97 jingxu97 mentioned this pull request Nov 16, 2016
Closed
k8s-github-robot pushed a commit that referenced this pull request Nov 16, 2016
Merge pull request #36920 from yujuhong/bump_image_version
43110dd 
Automatic merge from submit-queue

Bump gci image version for cri builds

#36681 didn't change all the configs.
@chentao1596 chentao1596 mentioned this pull request Dec 5, 2016
Closed
@mikedanese
Copy link
Member

Can we cherry pick this into 1.4?

@mikedanese
Copy link
Member

cc @dchen1107 @freehan

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vishh vishh vishh left review comments

@adityakali adityakali adityakali left review comments

Assignees

@vishh vishh

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
7 participants
@mtaufen @vishh @k8s-ci-robot @k8s-github-robot @mikedanese @adityakali @googlebot