Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove extensions/v1beta1 Job #38614

Merged
merged 5 commits into from
Dec 17, 2016
Merged

Remove extensions/v1beta1 Job #38614

merged 5 commits into from
Dec 17, 2016

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Dec 12, 2016 •
edited
Loading

Fixes #32763. This endpoint was deprecated in 1.5 and was planned to be removed in 1.6.

Release note:

Remove extensions/v1beta1 Jobs resource, and job/v1beta1 generator.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 12, 2016
@k8s-reviewable
Copy link

This change is Reviewable

@soltysh soltysh added area/batch release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 12, 2016
@k8s-github-robot k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/new-api size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 12, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit d1bdf755731a5a28d0a061f2287a4877cb285778. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins CRI GCE e2e failed for commit d1bdf755731a5a28d0a061f2287a4877cb285778. Full PR test history.

The magic incantation to run this job again is @k8s-bot cri e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@soltysh
Copy link
Contributor Author

soltysh commented Dec 12, 2016

@kubernetes/sig-apps @erictune ptal

@soltysh soltysh changed the title [WIP] Remove extensions/v1beta1 Job Remove extensions/v1beta1 Job Dec 12, 2016
@soltysh soltysh assigned erictune and unassigned thockin Dec 13, 2016
@soltysh
Copy link
Contributor Author

soltysh commented Dec 13, 2016

I'm tentatively assigning this to Eric, but he may choose somebody else from @kubernetes/sig-apps to be reviewer.

@0xmichalis
Copy link
Contributor

@kubernetes/sig-api-machinery may also be interested

@soltysh
Copy link
Contributor Author

soltysh commented Dec 13, 2016

Removed missed job/v1beta1 generator test in test-cmd.sh.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit 9746c7f7efaf4e7de07016e8294e14ecf54a5c1b. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@soltysh
Copy link
Contributor Author

soltysh commented Dec 13, 2016

Fixed integration compilation error.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 14, 2016
@soltysh
Copy link
Contributor Author

soltysh commented Dec 15, 2016

Rebased.

@soltysh soltysh removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins CRI GCE Node e2e failed for commit f957b28b02f8ea25d9fb1ac8662c2e7254494df9. Full PR test history.

The magic incantation to run this job again is @k8s-bot cri node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@soltysh
Copy link
Contributor Author

soltysh commented Dec 15, 2016

Rebased again, due to failures.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2016
@soltysh soltysh removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 16, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins Bazel Build failed for commit a64a9259b9ad4157ed8353e3cba937142b91c128. Full PR test history.

The magic incantation to run this job again is @k8s-bot bazel test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@soltysh
Copy link
Contributor Author

soltysh commented Dec 16, 2016

Rebased, but due to generation problems I had to include change to the generation (@caesarxuchao see first commit).

janetkuo
janetkuo approved these changes Dec 16, 2016
View reviewed changes
Copy link
Member

@janetkuo janetkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubectl changes LGTM

@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit a64a9259b9ad4157ed8353e3cba937142b91c128. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE Node e2e failed for commit 4188bb7. Full PR test history.

The magic incantation to run this job again is @k8s-bot node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@caesarxuchao
Copy link
Member

@k8s-bot node e2e test this

@caesarxuchao
Copy link
Member

/lgtm. Thanks.

@soltysh soltysh added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2016
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 37468, 36546, 38713, 38902, 38614)

@k8s-github-robot k8s-github-robot merged commit 6c9a413 into kubernetes:master Dec 17, 2016
@soltysh soltysh deleted the remove_ext_jobs branch December 17, 2016 19:52
@soltysh soltysh mentioned this pull request Dec 17, 2016
Merged
k8s-github-robot pushed a commit that referenced this pull request Dec 20, 2016
Merge pull request #38929 from soltysh/cronjob_gen_test
cc21520 
Automatic merge from submit-queue

Add test for CronJob generator

Per @janetkuo request this was split from #38614, it adds test for `CronJob` generator, and additionally copy labels to `JobTemplate`, to be consistent with how `Job` generator works.
@lukaszo lukaszo mentioned this pull request Dec 23, 2016
Closed
@soltysh soltysh mentioned this pull request Jan 18, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Jan 31, 2017
Merge pull request #40083 from soltysh/remove_extjobs
3e81148 
Automatic merge from submit-queue (batch tested with PRs 40405, 38601, 40083, 40730)

Remove extensions/v1beta1.Jobs leftover

It looks like I missed this one file when removing `extensions/v1beta1.Jobs` last time (#38614).

@caesarxuchao ptal, since you were reviewing last time
@kubernetes/sig-api-machinery-misc fyi
@soltysh soltysh mentioned this pull request Feb 3, 2017
Closed
@soltysh soltysh mentioned this pull request Mar 3, 2017
Closed
@soltysh soltysh mentioned this pull request Apr 20, 2017
Closed
@foxish foxish mentioned this pull request May 10, 2017
Closed
@v-antech v-antech mentioned this pull request Jul 3, 2017
Closed
@ravisantoshgudimetla ravisantoshgudimetla mentioned this pull request Jul 2, 2021
Closed
@Sea-n Sea-n mentioned this pull request Apr 14, 2022
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@caesarxuchao caesarxuchao caesarxuchao left review comments

@janetkuo janetkuo janetkuo approved these changes

Assignees

@caesarxuchao caesarxuchao

@janetkuo janetkuo

@erictune erictune

Labels
area/batch cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.