Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

enable DefaultTolerationSeconds admission controller by default #41815

Merged
merged 1 commit into from
Feb 26, 2017
Merged

enable DefaultTolerationSeconds admission controller by default #41815

merged 1 commit into from
Feb 26, 2017

Conversation

kevin-wangzefeng
Copy link
Member

@kevin-wangzefeng kevin-wangzefeng commented Feb 21, 2017 •
edited
Loading

What this PR does / why we need it:
Continuation of PR #41414, enable DefaultTolerationSeconds admission controller by default.

Which issue this PR fixes:
fixes: #41860
related Issue: #1574, #25320
related PRs: #34825, #41133, #41414

Special notes for your reviewer:

Release note:

enable DefaultTolerationSeconds admission controller by default

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 21, 2017
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 21, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@kevin-wangzefeng kevin-wangzefeng assigned davidopp and unassigned eparis Feb 21, 2017
@kevin-wangzefeng kevin-wangzefeng added this to the v1.6 milestone Feb 21, 2017
@kevin-wangzefeng
Copy link
Member Author

@davidopp PTAL.

@eparis
Copy link
Contributor

eparis commented Feb 21, 2017

/approve

@kevin-wangzefeng kevin-wangzefeng force-pushed the enable-defaulttolerationseconds-admission-controller branch from 4c44e64 to cd427fa Compare February 21, 2017 16:45
@deads2k
Copy link
Contributor

deads2k commented Feb 21, 2017

@derekwaynecarr @kubernetes/rh-cluster-infra

@aveshagarwal
Copy link
Member

@kevin-wangzefeng though changes look good, but in the original description, the issue it points to is your previous PR not an actual issue?

@kevin-wangzefeng
Copy link
Member Author

@aveshagarwal, do you mean the issue description? I refreshed a little bit, and added a link to the original feature discussion issue.

@davidopp
Copy link
Member

davidopp commented Feb 22, 2017 •
edited
Loading

Could someone from @kubernetes/sig-cluster-lifecycle-misc verify that this PR is the correct way to enable the DefaultTolerationSeconds admission controller across all environments?

And for good measure, cc/ @lavalamp @mikedanese

@aveshagarwal
Copy link
Member

@kevin-wangzefeng sgtm. thanks.

@davidopp
Copy link
Member

LGTM

Thanks!

I'm going to wait to approve until we merge #38957, just so people who run the code from HEAD don't end up with a bunch of annotations.

@davidopp
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2017
@davidopp davidopp added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

The following people have approved this PR: davidopp, eparis, kevin-wangzefeng

Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @mml @derekwaynecarr @jbeda
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 40932, 41896, 41815, 41309, 41628)

@k8s-github-robot k8s-github-robot merged commit 77ba346 into kubernetes:master Feb 26, 2017
@xilabao xilabao mentioned this pull request Feb 28, 2017
Closed
@davidopp davidopp mentioned this pull request Feb 28, 2017
Closed
@liggitt liggitt mentioned this pull request Mar 21, 2017
Closed
@davidopp davidopp mentioned this pull request Mar 21, 2017
Merged
@xilabao xilabao mentioned this pull request Apr 24, 2017
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@davidopp davidopp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

Enable "defaulttolerationseconds" admission controller by default for all providers
8 participants
@kevin-wangzefeng @k8s-reviewable @eparis @deads2k @aveshagarwal @davidopp @k8s-github-robot @k8s-ci-robot