-
Notifications
You must be signed in to change notification settings - Fork 39.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Find current resourceVersion for waiting for deletion/conditions #72825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
label
Jan 11, 2019
k8s-ci-robot
added
kind/bug
Categorizes issue or PR as related to a bug.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
needs-sig
Indicates an issue or PR lacks a `sig/foo` label and requires one.
needs-priority
Indicates a PR lacks a `priority/foo` label and requires one.
labels
Jan 11, 2019
/kind bug |
k8s-ci-robot
added
sig/cli
Categorizes an issue or PR as relevant to SIG CLI.
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/kubectl
sig/api-machinery
Categorizes an issue or PR as relevant to SIG API Machinery.
and removed
needs-sig
Indicates an issue or PR lacks a `sig/foo` label and requires one.
labels
Jan 11, 2019
liggitt
added
the
priority/critical-urgent
Highest priority. Must be actively worked on as someone's top priority right now.
label
Jan 11, 2019
k8s-ci-robot
removed
the
needs-priority
Indicates a PR lacks a `priority/foo` label and requires one.
label
Jan 11, 2019
deads2k
reviewed
Jan 11, 2019
optional nit, lgtm otherwise /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
liggitt
force-pushed
the
wait-resource-version
branch
from
January 11, 2019 20:24
50952d8
to
c12d8a5
Compare
resolved nit, tagging |
liggitt
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Jan 11, 2019
This was referenced Jan 11, 2019
/cc @jpbetz |
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 15, 2019
…5-upstream-release-1.12 Automated cherry pick of #72825: Find current resourceVersion for waiting for
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 15, 2019
…5-upstream-release-1.13 Automated cherry pick of #72825: Find current resourceVersion for waiting for
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 17, 2019
…5-upstream-release-1.11 Automated cherry pick of #72825: Find current resourceVersion for waiting for
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/kubectl
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/bug
Categorizes issue or PR as related to a bug.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
priority/critical-urgent
Highest priority. Must be actively worked on as someone's top priority right now.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
sig/api-machinery
Categorizes an issue or PR as relevant to SIG API Machinery.
sig/cli
Categorizes an issue or PR as relevant to SIG CLI.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Does a filtered list to get the current object and current resource version when waiting for deletion or for a condition
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
/cc @deads2k