Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bump NPD version to v0.7.1 for GCI #80726

Merged
merged 1 commit into from
Aug 28, 2019
Merged

Conversation

wangzhen127
Copy link
Member

@wangzhen127 wangzhen127 commented Jul 29, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR uses most recent NPD release (v0.7.1) for GCI.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Node-Problem-Detector v0.7.1 is used on GCI.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. kind/feature Categorizes issue or PR as related to a new feature. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 29, 2019
@wangzhen127
Copy link
Member Author

/sig node
/priority important-soon
/assign @Random-Liu
/assign @yguo0905
/cc @xueweiz

/hold
We should probably make a new NPD release v0.7.1 to include metrics support for custom plugins. Current v0.7.0 does not include that PR.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jul 29, 2019
@k8s-ci-robot
Copy link
Contributor

@wangzhen127: GitHub didn't allow me to request PR reviews from the following users: xueweiz.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/sig node
/priority important-soon
/assign @Random-Liu
/assign @yguo0905
/cc @xueweiz

/hold
We should probably make a new NPD release v0.7.1 to include metrics support for custom plugins. Current v0.7.0 does not include that PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 29, 2019
@xueweiz
Copy link

xueweiz commented Jul 29, 2019

By "to include metrics support for custom plugins", you meant #315 right?
I though it's already in 0.7.0?

@xueweiz
Copy link

xueweiz commented Jul 29, 2019

(sorry, just realized we are in different repo.
By "315", I meant this:
kubernetes/node-problem-detector#315

@wangzhen127
Copy link
Member Author

Ah, my bad, that is included already. I think we can just use v0.7.0 in k8S 1.16.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2019
@wangzhen127 wangzhen127 changed the title Bump NPD version to v0.7 for GCI Bump NPD version to v0.7.0 for GCI Jul 29, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 29, 2019
@wangzhen127
Copy link
Member Author

/test all

@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Jul 30, 2019
@wangzhen127 wangzhen127 force-pushed the npd-0.7 branch 2 times, most recently from 7b8cef8 to 28eac12 Compare July 30, 2019 17:12
@wangzhen127
Copy link
Member Author

/hold
Hold again. In this PR, I updated the E2E test to check KubeletStart event. Currently there is a race condition. On GKE, kubelet is restarted a few times when node is just booted. Those can happen before NPD is started. Without kubernetes/node-problem-detector#319, NPD may not find any kubelet start event if all the kubelet restarts happen before NPD is started.

We should decide if we want NPD to look back from the beginning of the boot time. If yes, we need a new v0.7.1 release to include the fix. If not, we should remove the E2E test update.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2019
@wangzhen127 wangzhen127 changed the title Bump NPD version to v0.7.0 for GCI Bump NPD version to v0.7.1 for GCI Aug 2, 2019
@wangzhen127
Copy link
Member Author

/hold cancel
@Random-Liu and @yguo0905, this is ready for review.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2019
@yguo0905
Copy link
Contributor

/lgtm
/approve
for cluster/gce/gci

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2019
@Random-Liu
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Random-Liu, wangzhen127, yguo0905

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit b9c6f55 into kubernetes:master Aug 28, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 28, 2019
@wangzhen127 wangzhen127 deleted the npd-0.7 branch August 28, 2019 21:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants