Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Wait for kubelet & kube-proxy to be ready on Windows node within 10s #85228

Merged
merged 1 commit into from
Nov 23, 2019
Merged

Wait for kubelet & kube-proxy to be ready on Windows node within 10s #85228

merged 1 commit into from
Nov 23, 2019

Conversation

YangLu1031
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Add wait for kubelet & kube-proxy to be ready on windows nodes within 10s. If not, throw exception and exit

Does this PR introduce a user-facing change?:

Wait for kubelet & kube-proxy to be ready on Windows node within 10s

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 13, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @YangLu1031. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 13, 2019
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 13, 2019
@YangLu1031
Copy link
Contributor Author

YangLu1031 commented Nov 13, 2019 •
edited
Loading

/cc pjh

@k8s-ci-robot k8s-ci-robot requested a review from pjh November 13, 2019 19:02
@pjh
Copy link
Contributor

pjh commented Nov 14, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 14, 2019
@pjh
Copy link
Contributor

pjh commented Nov 14, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 14, 2019
@pjh
Copy link
Contributor

pjh commented Nov 14, 2019

/test pull-kubernetes-e2e-windows-gce

@pjh
Copy link
Contributor

pjh commented Nov 14, 2019

/retest

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 14, 2019
@pjh
Copy link
Contributor

pjh commented Nov 14, 2019

/test pull-kubernetes-e2e-windows-gce

@k8s-ci-robot k8s-ci-robot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 14, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 14, 2019
@YangLu1031
Copy link
Contributor Author

/test pull-kubernetes-e2e-windows-gce

@YangLu1031
Copy link
Contributor Author

@YangLu1031: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-windows-gce 6bc5a18 link /test pull-kubernetes-e2e-windows-gce
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

The failing tests all happened in gce-windows-master testgrid as well. Looks like not caused by this PR.

@YangLu1031
Copy link
Contributor Author

@pjh Please take another look :)

@YangLu1031
Copy link
Contributor Author

/test pull-kubernetes-e2e-windows-gce

@pjh
Copy link
Contributor

pjh commented Nov 19, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pjh, YangLu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

2 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot
Copy link
Contributor

@YangLu1031: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-windows-gce 0965b57 link /test pull-kubernetes-e2e-windows-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@YangLu1031 YangLu1031 closed this Nov 19, 2019
@YangLu1031 YangLu1031 reopened this Nov 19, 2019
@YangLu1031
Copy link
Contributor Author

@pjh can we remove the pull-kubernetes-e2e-windows-gce test? it's failing the same as master, blocking the merge.

@pjh
Copy link
Contributor

pjh commented Nov 19, 2019

/skip pull-kubernetes-e2e-windows-gce

@yliaog
Copy link
Contributor

yliaog commented Nov 19, 2019

/skip

@YangLu1031
Copy link
Contributor Author

/milestone v1.17

@k8s-ci-robot
Copy link
Contributor

@YangLu1031: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 02c61b6 into kubernetes:master Nov 23, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Nov 23, 2019
YangLu1031 pushed a commit to YangLu1031/kubernetes that referenced this pull request Dec 12, 2019
@k8s-ci-robot @YangLu1031
Merge pull request kubernetes#85228 from YangLu1031/kubeproxyVerify
2e4abd5 
Wait for kubelet & kube-proxy to be ready on Windows node within 10s
@YangLu1031 YangLu1031 mentioned this pull request Dec 12, 2019
Closed
YangLu1031 pushed a commit to YangLu1031/kubernetes that referenced this pull request Dec 12, 2019
@k8s-ci-robot @YangLu1031
Merge pull request kubernetes#85228 from YangLu1031/kubeproxyVerify
4970b38 
Wait for kubelet & kube-proxy to be ready on Windows node within 10s
@YangLu1031 YangLu1031 mentioned this pull request Dec 12, 2019
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@pjh pjh pjh left review comments

@bowei bowei Awaiting requested review from bowei

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@pjh pjh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
5 participants
@YangLu1031 @k8s-ci-robot @pjh @fejta-bot @yliaog