Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Dependency update - Golang 1.23 #3650

Open
27 of 29 tasks
cpanato opened this issue Jun 24, 2024 · 11 comments
Open
27 of 29 tasks

Dependency update - Golang 1.23 #3650

cpanato opened this issue Jun 24, 2024 · 11 comments
Assignees
@cpanato
Labels
area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@cpanato
Copy link
Member

cpanato commented Jun 24, 2024 •
edited
Loading

Tracking info

Link to any previous tracking issue: #3280

Golang mailing list announcement: https://groups.google.com/g/golang-announce/c/8ciOP5ve_CM/m/fg9_BQpdFgAJ

SIG Release Slack thread: https://kubernetes.slack.com/archives/CJH2GBF7Y/p1719215856518939

Work items for go1.23.0

After go-runner image promotion

Work items for go1.23rc1

After go-runner image promotion

Work items for go1.23rc2

After go-runner image promotion

After kube-cross and distroless-iptables image promotions

Note
This update may require an update to go.sum files, for example: kubernetes/kubernetes#118507
This will require an API Review approval.

After kubernetes/kubernetes (master) has been updated

Follow-up items

  • Ensure the Golang issue template is updated with any new requirements

/assign
cc: @kubernetes/release-engineering
@cpanato cpanato added kind/feature Categorizes issue or PR as related to a new feature. sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject area/dependency Issues or PRs related to dependency changes labels Jun 24, 2024
@cpanato
Copy link
Member Author

cpanato commented Jun 24, 2024

cc @MadhavJivrajani @liggitt

@cpanato cpanato mentioned this issue Jul 5, 2024
Merged
@MadhavJivrajani
Copy link

MadhavJivrajani commented Jul 5, 2024 •
edited
Loading

Tracking PRs related to go1.23 that we would need to pick to release branches as part of an eventual update to go1.23:

Tracking verification of conditions for bumping go1.21 on release branches:

  • TBD: 3 months after go 1.22 release (TBD)
  • TBD: 1 month after Kubernetes 1.30/Kubernetes 1.31 release on go1.23 (TBD)
  • no regressions relative to go 1.23 known to impact Kubernetes
    • [ ]
  • pass unit and integration tests with both go 1.23 and the original go version for the release branch
    • 1.27:
    • 1.28:
    • 1.29:
  • any behavior changes in go 1.23 are mitigated to preserve existing behavior without requiring action by Kubernetes end-users
    • 1.28:
    • 1.29:
    • 1.30:

Tracking the PR that actually bumps to go1.22:

    • 1.28:
    • 1.29:
    • 1.30

@MadhavJivrajani MadhavJivrajani mentioned this issue Jul 5, 2024
Merged
This was referenced Jul 8, 2024
Merged
Merged
Merged
@cpanato
Copy link
Member Author

cpanato commented Jul 16, 2024

RC2 released: https://groups.google.com/g/golang-announce/c/jW315Nz132s/m/WqkCDaiVBQAJ

This was referenced Jul 17, 2024
Merged
Merged
This was referenced Jul 24, 2024
Merged
Closed
@pacoxu
Copy link
Member

pacoxu commented Jul 29, 2024

#3685 post run of this PR failed:

@liggitt
Copy link
Member

liggitt commented Aug 20, 2024

go 1.23.0 is out now, can rebump master to 1.23 now 🎉

This was referenced Aug 28, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@cpanato
Copy link
Member Author

cpanato commented Sep 3, 2024

all done

/close

@k8s-ci-robot
Copy link
Contributor

@cpanato: Closing this issue.

In response to this:

all done

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cpanato cpanato mentioned this issue Sep 4, 2024
Open
@liggitt
Copy link
Member

liggitt commented Sep 4, 2024

should we keep this open for tracking changes required for go 1.23 (like #3280 (comment)), and backport of 1.23 to release branches?

@cpanato
Copy link
Member Author

cpanato commented Sep 4, 2024

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Sep 4, 2024
@k8s-ci-robot
Copy link
Contributor

@cpanato: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@liggitt liggitt mentioned this issue Sep 10, 2024
Merged
@liggitt
Copy link
Member

liggitt commented Sep 10, 2024

Can we add an item to #3650 (comment) to pick the godebug default=go1.x commit from kubernetes/kubernetes#127271 to release branch go.mod files?

xref https://tip.golang.org/doc/godebug#default

This was referenced Sep 10, 2024
Closed
Closed
@liggitt liggitt mentioned this issue Sep 20, 2024
Open
29 tasks
henrybear327 added a commit to henrybear327/etcd that referenced this issue Sep 26, 2024
@henrybear327
Bump go toolchain to 1.23.0
6369020 
Reference:
- https://github.com/etcd-io/etcd/issues/18543
- kubernetes/release#3650

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
@henrybear327 henrybear327 mentioned this issue Sep 26, 2024
Merged
henrybear327 added a commit to henrybear327/etcd that referenced this issue Sep 26, 2024
@henrybear327
Bump go toolchain to 1.23.1
dcdfead 
Reference:
- https://github.com/etcd-io/etcd/issues/18543
- kubernetes/release#3650

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
a-nych pushed a commit to a-nych/etcd that referenced this issue Oct 16, 2024
@henrybear327 @a-nych
Bump go toolchain to 1.23.1
8849a4f 
Reference:
- https://github.com/etcd-io/etcd/issues/18543
- kubernetes/release#3650

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
a-nych pushed a commit to a-nych/etcd that referenced this issue Oct 16, 2024
@henrybear327 @a-nych
Bump go toolchain to 1.23.1
8195c77 
Reference:
- https://github.com/etcd-io/etcd/issues/18543
- kubernetes/release#3650

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
This was referenced Dec 23, 2024
Open
Open
@liggitt liggitt mentioned this issue Jan 7, 2025
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@cpanato cpanato

Labels
area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@liggitt @pacoxu @cpanato @MadhavJivrajani @k8s-ci-robot