-
Notifications
You must be signed in to change notification settings - Fork 505
Add build to krel stage
#1692
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merged
Merged
Add build to krel stage
#1692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new `build` package which will be used to build a release version. The integration in `krel stage` allows us now to build single releases, whereas the tagging (currently `TODO`) of the release has to be finished as a follow-up. Signed-off-by: Sascha Grunert <sgrunert@suse.com>
/assign @justaugustus |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/release-eng
Issues or PRs related to the Release Engineering subproject
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/feature
Categorizes issue or PR as related to a new feature.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
needs-priority
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
sig/release
Categorizes an issue or PR as relevant to SIG Release.
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This adds a new
build
package which will be used to build a releaseversion. The integration in
krel stage
allows us now to build singlereleases, whereas the tagging (currently
TODO
) of the release has tobe finished as a follow-up.
Which issue(s) this PR fixes:
Refers to #1673
Special notes for your reviewer:
Requires #1689
Does this PR introduce a user-facing change?