Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

label_sync(releng): Add area/release-eng label to kubernetes/website #22272

Merged
merged 1 commit into from
May 20, 2021
Merged

label_sync(releng): Add area/release-eng label to kubernetes/website #22272

merged 1 commit into from
May 20, 2021

Conversation

justaugustus
Copy link
Member

SIG Release / Release Engineering content is actively being migrated
to kubernetes/website. This gives us a way to label/filter issues/PRs
for review.

Signed-off-by: Stephen Augustus foo@auggie.dev

Needed for kubernetes/website#27997.
cc: @kubernetes/release-engineering @sftim

@justaugustus
label_sync(releng): Add area/release-eng label to kubernetes/website
1b57607 
SIG Release / Release Engineering content is actively being migrated
to kubernetes/website. This gives us a way to label/filter issues/PRs
for review.

Signed-off-by: Stephen Augustus <foo@auggie.dev>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/label_sync Issues or PRs related to code in /label_sync sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 20, 2021
@k8s-ci-robot k8s-ci-robot requested review from fejta and spiffxp May 20, 2021 02:32
@justaugustus
Copy link
Member Author

/hold for a signoff from @kubernetes/sig-docs-en-owners
/assign @cblecker @fejta @spiffxp

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2021
@justaugustus justaugustus mentioned this pull request May 20, 2021
Merged
4 tasks
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 20, 2021
cpanato
cpanato approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

saschagrunert
saschagrunert approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

xmudrii
xmudrii approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, fejta, justaugustus, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sftim
Copy link
Contributor

sftim commented May 20, 2021

We should document when to use /sig release vs. when to use /area release-engineering (for k/website, I mean).

/lgtm
as SIG Docs technical lead

@justaugustus
Copy link
Member Author

We should document when to use /sig release vs. when to use /area release-engineering (for k/website, I mean).

SGTM!
I think, at least for now, either label is fine, but that may change if/when we move pages around.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit 05ef898 into kubernetes:master May 20, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 20, 2021
@k8s-ci-robot
Copy link
Contributor

@justaugustus: Updated the label-config configmap in namespace test-pods at cluster test-infra-trusted using the following files:

  • key labels.yaml using file label_sync/labels.yaml

In response to this:

SIG Release / Release Engineering content is actively being migrated
to kubernetes/website. This gives us a way to label/filter issues/PRs
for review.

Signed-off-by: Stephen Augustus foo@auggie.dev

Needed for kubernetes/website#27997.
cc: @kubernetes/release-engineering @sftim

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@fejta fejta fejta approved these changes

@cpanato cpanato cpanato approved these changes

@xmudrii xmudrii xmudrii approved these changes

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@spiffxp spiffxp

@saschagrunert saschagrunert

@fejta fejta

@cblecker cblecker

@cpanato cpanato

@xmudrii xmudrii

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/label_sync Issues or PRs related to code in /label_sync cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
9 participants
@justaugustus @k8s-ci-robot @sftim @saschagrunert @fejta @cpanato @xmudrii @spiffxp @cblecker