Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix VolumeSubpathEnvExpansion feature gate #17576

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Nov 14, 2019

Move the VolumeSubpathEnvExpansion feature gate information out of the Feature gates for Alpha or Beta features section.

@daminisatya: this is a fixup for #16547

/kind cleanup
/milestone 1.17

@k8s-ci-robot
Copy link
Contributor

@sftim: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

Move the VolumeSubpathEnvExpansion feature gate information out of the Feature gates for Alpha or Beta features section.

@daminisatya: this is a fixup for #16547

/kind cleanup
/milestone 1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 14, 2019
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 0a3cbd3

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5dcd3d5f9f0af8000793e4d8

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 14, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 14, 2019
@tengqm tengqm added this to the 1.17 milestone Nov 18, 2019
@kbhawkey
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2019
@daminisatya
Copy link
Contributor

Thank you @sftim

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daminisatya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit af7e2ec into kubernetes:dev-1.17 Nov 22, 2019
@kbhawkey kbhawkey mentioned this pull request Dec 6, 2019
@sftim sftim deleted the 20191114_fix_volumesubpathenvexpansion_feature_gate branch June 9, 2021 17:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants