Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

node: cpumgr: docs: Kubelet CPU Manager GA graduation #37686

Merged
merged 1 commit into from
Nov 13, 2022

Conversation

ffromani
Copy link
Contributor

@ffromani ffromani commented Nov 3, 2022

Docs update for Kubelet CPU Manager GA graduation.
Issue: kubernetes/enhancements#3570

Replaces #37288 which was mistakenly filed against main branch

Signed-off-by: Francesco Romani fromani@redhat.com

@k8s-ci-robot k8s-ci-robot added this to the 1.26 milestone Nov 3, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 3, 2022
@netlify
Copy link

netlify bot commented Nov 3, 2022

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 25771e9
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/636e7386071a36000888fc5d

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 3, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 3, 2022
@ffromani
Copy link
Contributor Author

ffromani commented Nov 3, 2022

/cc @sftim @klueska
which were reviewing the previous PR.
Since last version of #37288 addressed pending comments

@k8s-ci-robot k8s-ci-robot requested review from klueska and sftim November 3, 2022 07:58
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2022
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 9, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2022
@ffromani
Copy link
Contributor Author

rebased and ready for another round of review

Signed-off-by: Francesco Romani <fromani@redhat.com>
Copy link
Contributor

@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
from node-perspective

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6c04008c18768df654eb3a18f3d48782665d0df7

@tengqm
Copy link
Contributor

tengqm commented Nov 13, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit dac056c into kubernetes:dev-1.26 Nov 13, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants