Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixes nav errors introduced in #4694 #4888

Merged
merged 9 commits into from
Aug 17, 2017
Merged

Fixes nav errors introduced in #4694 #4888

merged 9 commits into from
Aug 17, 2017

Conversation

zacharysarah
Copy link
Contributor

@zacharysarah zacharysarah commented Aug 15, 2017

/ref #4694

This PR:


This change is Reviewable

@zacharysarah zacharysarah self-assigned this Aug 15, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 15, 2017
@zacharysarah zacharysarah mentioned this pull request Aug 15, 2017
@zacharysarah
Copy link
Contributor Author

@chenopis 👋 The second section heading renders properly in the preview, but not the first. Any suggestions?

screen shot 2017-08-14 at 11 40 33 pm

section:
- title: Scalable Microservices with Kubernetes (Udacity)
path: https://www.udacity.com/course/scalable-microservices-with-kubernetes--ud615
section:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line; both links can be under the same section

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview ready!

Built with commit 52806f2

https://deploy-preview-4888--kubernetes-io-master-staging.netlify.com

@chenopis chenopis merged commit b8a0fbb into kubernetes:master Aug 17, 2017
@zacharysarah zacharysarah deleted the 4694-nav-fix branch August 17, 2017 21:49
@zacharysarah
Copy link
Contributor Author

@dankohn The tutorial links (#4694) should work now.

chenopis added a commit that referenced this pull request Aug 17, 2017
…hub.io into chenopis-glossary-project

* 'master' of https://github.com/kubernetes/kubernetes.github.io: (75 commits)
  Update configure-cloud-provider-firewall.md
  Update apparmor.md
  Update apparmor.md
  [minor] Grammar
  [minor] Grammar and typo
  [minor] Grammar and typo
  Update authenticate-across-clusters-kubeconfig.md
  Fixes nav errors introduced in #4694 (#4888)
  Update rbac.md (#4973)
  Update manual.md (#4974)
  Update securing-a-cluster.md (#4975)
  Update configure-upgrade-etcd.md (#4978)
  Update namespaces.md (#4981)
  Update http-proxy-access-api.md (#4982)
  JSONPath: rename title (#4986)
  Update labels-annotations-taints.md (#4987)
  Update index.md (#4988)
  Update clc.md (#4989)
  Update kubectl-overview.md (#4990)
  Update out-of-resource.md (#4992)
  ...
jesscodez pushed a commit that referenced this pull request Sep 22, 2017
* Fixing tutorial dropdown nav

* Changed indentation levels

* Syntax fix

* Trying to get Udacity to work

* Removed a redundant section heading
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants