-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fixed link navigation bug #49414
Fixed link navigation bug #49414
Conversation
Signed-off-by: aakankshabhende <aakanksha0407@gmail.com>
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
content/en/docs/tutorials/configuration/updating-configuration-via-a-configmap.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant the line 433 which explains what is sidecar container. What do you suggest? @dipesh-rawat
@aakankshabhende, @dipesh-rawat , The tutorial to update ConfigMaps was originally added to the documentation prior to v1.29, and hence there was a need to enable the Sidecar container feature through a feature gate, which was documented here. Since v1.29, this is no longer needed as the feature is enabled by default. So the corresponding section has been removed from the Sidecar container page, resulting in the broken link. The best fix would be to remove the following line from the documentation altogether:
|
content/en/docs/tutorials/configuration/updating-configuration-via-a-configmap.md
Outdated
Show resolved
Hide resolved
Signed-off-by: aakankshabhende <aakanksha0407@gmail.com>
/lgtm |
LGTM label has been added. Git tree hash: 4af6606c8e7769fb78dad60fdfa3ac3ab1dbab38
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
The subsection "Update configuration via a ConfigMap in a Pod possessing a sidecar container" contains the sentence:
The sidecar-containers page doesn't have a subsection on enabling sidecar containers, so I navigated the link to example showing deployment having sidecar config.
Issue
Closes: #49326