Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed link navigation bug #49414

Merged
merged 2 commits into from
Feb 16, 2025
Merged

Fixed link navigation bug #49414

merged 2 commits into from
Feb 16, 2025

Conversation

aakankshabhende
Copy link
Member

Description

The subsection "Update configuration via a ConfigMap in a Pod possessing a sidecar container" contains the sentence:

Please see Enabling sidecar containers to utilize this feature.

The sidecar-containers page doesn't have a subsection on enabling sidecar containers, so I navigated the link to example showing deployment having sidecar config.

Issue

Closes: #49326

Signed-off-by: aakankshabhende <aakanksha0407@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Jan 13, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 13, 2025
Copy link

netlify bot commented Jan 13, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 05bebe3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6799d0474dc180000886d54a
😎 Deploy Preview https://deploy-preview-49414--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member Author

@aakankshabhende aakankshabhende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant the line 433 which explains what is sidecar container. What do you suggest? @dipesh-rawat

@adityasamant25
Copy link
Contributor

@aakankshabhende, @dipesh-rawat ,

The tutorial to update ConfigMaps was originally added to the documentation prior to v1.29, and hence there was a need to enable the Sidecar container feature through a feature gate, which was documented here.

Since v1.29, this is no longer needed as the feature is enabled by default. So the corresponding section has been removed from the Sidecar container page, resulting in the broken link.

The best fix would be to remove the following line from the documentation altogether:

Please see Enabling sidecar containers to utilize this feature.

Signed-off-by: aakankshabhende <aakanksha0407@gmail.com>
@AmarNathChary
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4af6606c8e7769fb78dad60fdfa3ac3ab1dbab38

@sftim
Copy link
Contributor

sftim commented Feb 16, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2025
@k8s-ci-robot k8s-ci-robot merged commit 75faa38 into kubernetes:main Feb 16, 2025
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating Configuration via a ConfigMap
7 participants