-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
user-namespaces: add idsPerPod configuration #49749
base: dev-1.33
Are you sure you want to change the base?
Conversation
cc @rata |
4691c9c
to
5b52434
Compare
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Left an idea of a possible clarification, but I'm not the best with wordings, feel free to leave it out :D
@AkihiroSuda the change LGTM, however I just realize it's against the wrong branch. See the comment, it should be against the branch dev-1.33. Can you adjust that? |
5b52434
to
83c1b41
Compare
Kubernetes v1.33 will support setting `userNamespaces.idsPerPod` in `KubeletConfiguration`. Depends on k/k PR 130028 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
83c1b41
to
ba6bf9d
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rata The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AkihiroSuda found another place we needed to update, left a suggestion on how to change it. Other than that, I think you can mark this PR as ready for review :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file, above this diff says:
The valid UIDs/GIDs when this feature is enabled is the range 0-65535. This applies to files and processes (runAsUser, runAsGroup, etc.).
Files using a UID/GID outside this range will be seen as belonging to the overflow ID, usually 65534 (configured in /proc/sys/kernel/overflowuid and /proc/sys/kernel/overflowgid). However, it is not possible to modify those files, even by running as the 65534 user/group.
What if we add a note there (a "by default" in the first paragraph and a note after these two paragraphs), like:
By default, the valid UIDs/GIDs when this feature is enabled is the range 0-65535. This applies to files and processes (runAsUser, runAsGroup, etc.).
Files using a UID/GID outside this range will be seen as belonging to the overflow ID, usually 65534 (configured in /proc/sys/kernel/overflowuid and /proc/sys/kernel/overflowgid). However, it is not possible to modify those files, even by running as the 65534 user/group.
If the range 0-65536 is extended with a configuration knob, the aforementioned restrictions apply to the extended range.
Description
Kubernetes v1.33 will support setting
userNamespaces.idsPerPod
inKubeletConfiguration
.Depends on:
Issue
Closes: NONE