Remove a bad example for selector defaulting #5665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
Deploy preview ready! Built with commit 13d2a98 https://deploy-preview-5665--kubernetes-io-master-staging.netlify.com |
chenopis
suggested changes
Sep 28, 2017
| @@ -23,7 +23,7 @@ This is a living document. If you think of something that is not on this list bu | |||
|
|
|||
| Note also that many `kubectl` commands can be called on a directory, so you can also call `kubectl create` on a directory of config files. See below for more details. | |||
|
|
|||
| - Don't specify default values unnecessarily, in order to simplify and minimize configs, and to reduce error. For example, omit the selector and labels in a `ReplicationController` if you want them to be the same as the labels in its `podTemplate`, since those fields are populated from the `podTemplate` labels by default. See the [guestbook app's](https://github.com/kubernetes/examples/tree/{{page.githubbranch}}/guestbook/) .yaml files for some [examples](https://github.com/kubernetes/examples/tree/{{page.githubbranch}}/guestbook/frontend-deployment.yaml) of this. | |||
| - Don't specify default values unnecessarily, in order to simplify and minimize configs, and to reduce error. | |||
There was a problem hiding this comment.
suggested edit: "Don't specify default values unnecessarily -- simple and minimal config files will reduce errors."
tengqm
force-pushed
the
fix-config-overview
branch
from
cbdbba0 to
13d2a98
Compare
chenopis
approved these changes
Sep 29, 2017
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a rapidly changing world, a previously encouraged practice is now becoming invalid. We should at least stop advocating such practices in the docs.
Changes made: remove a bad example that depends on old behavior of selector defaulting.
xref: #5650
This change is