Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

🧼 ephrase the text label for the preserveStaticIPs flag #1139

Merged
merged 1 commit into from
May 6, 2024
Merged

🧼 ephrase the text label for the preserveStaticIPs flag #1139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/forklift-console-plugin/locales/en/plugin__forklift-console-plugin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@
"Details": "Details",
"Determines the frequency with which the system checks the status of snapshot creation or removal during oVirt warm migration. The default value is 10 seconds.": "Determines the frequency with which the system checks the status of snapshot creation or removal during oVirt warm migration. The default value is 10 seconds.",
"Disk Transfer": "Disk Transfer",
"Do not try to preserve the static IPs of VMs with Windows guest operating system from vSphere.": "Do not try to preserve the static IPs of VMs with Windows guest operating system from vSphere.",
"Domain": "Domain",
"Domain name": "Domain name",
"Drag and drop a file or upload one": "Drag and drop a file or upload one",
Expand Down Expand Up @@ -336,7 +337,7 @@
"Preserve CPU model": "Preserve CPU model",
"Preserve static IPs": "Preserve static IPs",
"Preserve the CPU model and flags the VM runs with in its oVirt cluster.": "Preserve the CPU model and flags the VM runs with in its oVirt cluster.",
"Preserve the static IPs that the VM runs with in vSphere provider's environment.": "Preserve the static IPs that the VM runs with in vSphere provider's environment.",
"Preserve the static IPs of VMs with Windows guest operating system from vSphere.": "Preserve the static IPs of VMs with Windows guest operating system from vSphere.",
"Product": "Product",
"Project": "Project",
"Project ID": "Project ID",
Expand Down
2 changes: 1 addition & 1 deletion ...lans/views/details/components/SettingsSection/components/PreserveStaticIPsDetailsItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export const PreserveStaticIPsDetailsItem: React.FC<PlanDetailsItemProps> = ({
const { showModal } = useModal();

const defaultHelpContent = t(
`Preserve the static IPs that the VM runs with in vSphere provider's environment.`,
`Preserve the static IPs of VMs with Windows guest operating system from vSphere.`,
);

const trueLabel = (
Expand Down
12 changes: 9 additions & 3 deletions ...components/SettingsSection/modals/EditPlanPreserveStaticIPs/EditPlanPreserveStaticIPs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ interface SwitchRendererProps {
}

const PreserveStaticIPsInputFactory: () => ModalInputComponentType = () => {
const { t } = useForkliftTranslation();

const SwitchRenderer: React.FC<SwitchRendererProps> = ({ value, onChange }) => {
const onChangeInternal = (v) => {
onChange(v ? 'true' : 'false');
Expand All @@ -46,8 +48,12 @@ const PreserveStaticIPsInputFactory: () => ModalInputComponentType = () => {
return (
<Switch
id="simple-switch"
label="Preserve the static IPs that the VM runs with in vSphere provider's environment."
labelOff="Do not try to preserve the static IPs that the VM runs with in vSphere provider's environment."
label={t(
yaacov marked this conversation as resolved.
Show resolved Hide resolved
'Preserve the static IPs of VMs with Windows guest operating system from vSphere.',
)}
labelOff={t(
'Do not try to preserve the static IPs of VMs with Windows guest operating system from vSphere.',
)}
isChecked={value === 'true'}
onChange={onChangeInternal}
/>
Expand All @@ -68,7 +74,7 @@ const EditPlanPreserveStaticIPs_: React.FC<EditPlanPreserveStaticIPsProps> = (pr
label={props?.label || t('Whether to preserve the static IPs')}
model={PlanModel}
onConfirmHook={onConfirm}
body={t(`Preserve the static IPs that the VM runs with in vSphere provider's environment.`)}
body={t(`Preserve the static IPs of VMs with Windows guest operating system from vSphere.`)}
InputComponent={PreserveStaticIPsInputFactory()}
/>
);
Expand Down