Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

🧼 Better luks help #1214

Merged
merged 1 commit into from
Jun 16, 2024
Merged

🧼 Better luks help #1214

merged 1 commit into from
Jun 16, 2024

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Jun 16, 2024

Issue:
the help for LUKS keys is too short

Screeshots:
Before:
luks-help-before

After:
luks-after

@yaacov yaacov added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 16, 2024
@yaacov yaacov added this to the 2.7.0 milestone Jun 16, 2024
@RichardHoch
Copy link

RichardHoch commented Jun 16, 2024

@yaacov @ahadas @anarnold97: Kobi asked me to edit the text in the second screen capture above. Please review the following:

Disk decryption passphrases

Specify a list of passphrases for the Linux Unified Key Setup (LUKS)-encrypted devices for the VMs that you want to migrate.

For each LUKS-encrypted device, Migration Toolkit for Virtualization (MTV) tries each passphrase until one unlocks the device. [Learn more]

Passphrases for LUKS-encrypted devices

(+) Add passphrase

Signed-off-by: yaacov <kobi.zamir@gmail.com>
@yaacov yaacov force-pushed the better-luks-help branch from 23696b4 to f8a5e38 Compare June 16, 2024 11:16
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yaacov
Copy link
Member Author

yaacov commented Jun 16, 2024

@RichardHoch thank you for the review.

Changes:

- addButtonText={t('Add Passphrase')}
+ addButtonText={t('Add passphrase')}

- title={props?.title || t('Disk decryption keys')}
+ title={props?.title || t('Disk decryption passphrases')}

- Specify a list of keys for Linux Unified Key Setup (LUKS) encrypted devices in order to
- convert the VM.
+ Specify a list of passphrases for the Linux Unified Key Setup (LUKS)-encrypted devices for
+ the VMs that you want to migrate.

- If you use more then one passphrase, you can add more then one passphrase, migration toolkit
- for virtualization (MTV) will try each passphrase until one will unlock the device,{' '}
+ For each LUKS-encrypted device, Migration Toolkit for Virtualization (MTV) tries each
+ passphrase until one unlocks the device.{' '}

-  learn more
+ Learn more

@yaacov yaacov merged commit fc1b129 into kubev2v:main Jun 16, 2024
8 checks passed
@yaacov yaacov modified the milestones: 2.7.0, 2.6.3 Jun 20, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants