Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Refactor the concern cell renderer #738

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Refactor the concern cell renderer #738

merged 1 commit into from
Sep 20, 2023

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Sep 20, 2023

Folowup for: #733

Refactor the concerns cell renderer

  • add jdoc
  • use Concern type instead of ConcernCategories
  • use getters instead of direct access to dictionaries
  • add translations
  • be more explicit about groupConcernsByCategory output

@yaacov
Refactor the concern cell renderer
c9f3d66 
Signed-off-by: yzamir <kobi.zamir@gmail.com>
@yaacov yaacov added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 20, 2023
@yaacov yaacov added this to the 2.5.2 milestone Sep 20, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yaacov yaacov merged commit 5044244 into kubev2v:main Sep 20, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sjd78 sjd78 Awaiting requested review from sjd78

@sgratch sgratch Awaiting requested review from sgratch

@rszwajko rszwajko Awaiting requested review from rszwajko

Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
2.5.2
Development

Successfully merging this pull request may close these issues.
1 participant
@yaacov