Enhance EditModal to refresh the helperText field value based on validationHook result #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dationHook result For supporting refreshing the helperText field value displayed, based on the ValidationResults (e.g., success, warning), need to set it to the validation.helperText value instead of the constant helperText prop value. If validation.helperText is set to '' (initial state or for backward compatible use), then use the initial helperText prop as was done before this fix. Signed-off-by: Sharon Gratch <sgratch@redhat.com>
sgratch
force-pushed
the
editModal-update-helptext-when-valueChanged
branch
from
832970d to
3485608
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Enable refreshing the displayed value of the
helperTextfield of theEditModalcomponent, based on theValidationResults(e.g., success, warning), need to set it to thevalidation.helperTextvalue instead of the constanthelperTextprop value.If
validation.helperTextis set to an empty string''(in case of an initial state or for backward compatible use), then use the initialhelperTextprop as was done before this fix.