🐞 Add margin under section headers #829
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
in console 4.15 we changed some css classes, one of them is the margin below a section header
Fix:
Add the missing margin by using
h2
instead ofTitle
, wrap theh2
in custom component to hide the not nice use ofh2
Screenshots
![no-margin](https://private-user-images.githubusercontent.com/2181522/297404502-5e538c0b-0b8a-4ef1-884d-93d4409e43de.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2OTkzMDIsIm5iZiI6MTczOTY5OTAwMiwicGF0aCI6Ii8yMTgxNTIyLzI5NzQwNDUwMi01ZTUzOGMwYi0wYjhhLTRlZjEtODg0ZC05M2Q0NDA5ZTQzZGUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTZUMDk0MzIyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NTRkZDljMzRkNDI0NmFiZTk5NDQ0M2IyN2I4ZDhiY2FhNjI2YTg5MzkwNTA4ZDdlNDY0Y2MxNWUzMmZkNGRiMSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.WeSNIMHgoL3F1hKOHCW8hxKl1jDFSmxyqlU6WvDIfYc)
Before:
After:
![with-margin](https://private-user-images.githubusercontent.com/2181522/297404551-8b6beb52-6816-4f9e-a5f9-20cdc2f6ea5b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2OTkzMDIsIm5iZiI6MTczOTY5OTAwMiwicGF0aCI6Ii8yMTgxNTIyLzI5NzQwNDU1MS04YjZiZWI1Mi02ODE2LTRmOWUtYTVmOS0yMGNkYzJmNmVhNWIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTZUMDk0MzIyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OTg0OTI0ZmZlYTA3ODU4ZDI2YTM0Njk2MTU2Y2I1ZDZjYTU4ZTJjM2FhZWYyY2FmOTZhMGMyNDA3NmI0ZDA1MCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.UoYonp7iM9OswJxE69o1UKW_eR-HwOQAxcUyUMNgSFQ)