Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

🐞 Add margin under section headers #829

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Jan 17, 2024

Issue:
in console 4.15 we changed some css classes, one of them is the margin below a section header

Fix:
Add the missing margin by using h2 instead of Title, wrap the h2 in custom component to hide the not nice use of h2

Screenshots
Before:
no-margin

After:
with-margin

@yaacov
Copy link
Member Author

yaacov commented Jan 17, 2024

@rszwajko - ping note this affect also the new plan form

@yaacov
Copy link
Member Author

yaacov commented Jan 17, 2024

addressing: #830

@yaacov yaacov added this to the 2.6.0 milestone Jan 17, 2024
@yaacov yaacov added the bug Categorizes issue or PR as related to a bug. label Jan 17, 2024
Signed-off-by: Yaacov Zamir <kobi.zamir@gmail.com>
@yaacov yaacov force-pushed the add-section-headers branch from 84c130c to 542da60 Compare January 17, 2024 14:40
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yaacov yaacov merged commit 18c46ee into kubev2v:main Jan 17, 2024
7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant