Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: use more stricter golang linter configuration. #71

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

jvanz
Copy link
Member

@jvanz jvanz commented Jul 15, 2024

Description

Updates the golang linter configuration to be more stricter. The used configuration is originally written by Marat Reymers

Related to kubewarden/kubewarden-controller#778

jvanz added 3 commits July 15, 2024 16:12
Updates the golang linter configuration to be more stricter. The used
configuration is originally written by Marat Reymers

Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
Adapts the golden config for golang linter from Marat Reymers to the
CEL policy needs.

Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
Updates the code of the policy to make the linter happy again after the
update in its configuration.

Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
@jvanz jvanz self-assigned this Jul 15, 2024
@jvanz jvanz requested a review from a team as a code owner July 15, 2024 19:16
Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

Signed-off-by: Flavio Castelli <flavio@castelli.me>
@flavio flavio merged commit 1a566b7 into kubewarden:main Jul 16, 2024
4 checks passed
@jvanz jvanz deleted the golinter branch July 16, 2024 12:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants