Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
controller-runtime to 0.5.1
kubectl to 0.17.3
controller-tools v0.2.6
Closely tied to: kudobuilder/kudo#1420
In fact the PR had more affect on testing and kuttl than on the rest of kudo.
Gotchas:
For some harness tests, I had to edit our test CRDs like:
With new kubectl version, the original name had multiple problems:
k8s.io
are restricted and now require anapi-approved.kubernetes.io
annotation pointing to a PR which introduced themreason: ApprovedAnnotation
thus bringing the number ofstatus.condition
s to three. These conditions would sometimes arrive out of order, however, test harness does not support the same order of elements when comparing two arrays, thus making the tests flaky. See this thread for more details.Signed-off-by: Ken Sipe kensipe@gmail.com