Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add unit under test declaration KEP. #3

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Conversation

jbarrick-mesosphere
Copy link
Member

No description provided.

Signed-off-by: jbarrick@mesosphere.com <jbarrick@mesosphere.com>
Copy link
Member

@nfnt nfnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! One potential implentation detail not mentioned here is logging of multiple background commands. The solution should ensure that users can distinguish between the output of different background commands.

@jbarrick-mesosphere
Copy link
Member Author

Great addition! One potential implentation detail not mentioned here is logging of multiple background commands. The solution should ensure that users can distinguish between the output of different background commands.

Oh yes, that's a great point. I'll add some details here.

@jbarrick-mesosphere
Copy link
Member Author

I need to think about that a little bit @nfnt. We're going to want to label the output, something like:

[command that is running] log line

If we want to the label the output, what do we think would be the best thing to label it with?

  • Some index just so they are unique (e.g., command-1).
  • A truncated form of the command (kubectl create -f blah..).
  • A user provided label (maybe default to index if not provided?).

The other option might be to colorize each command's output differently.

Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great write up! I'm good with merging as draft or provisional.

I would like one of the alternatives as a preference... it feels like command in isolation is really abstract. I think I like controller or controller-command. OR something that more clearly indicates that this is a "setup" command. Perhaps we need additional normal testing lifecycle hooks as well... setupSuite, setup, teardown, teardownSuite?

@gerred
Copy link
Member

gerred commented Feb 19, 2020

👍 to merging as draft. @jbarrick-mesosphere if you're OK driving this forward to implementation, work can start on the comments and implementation in the next PR.

@gerred gerred merged commit dd3bc08 into master Feb 19, 2020
@kensipe kensipe deleted the unit-under-test-kep branch April 30, 2021 20:49
NxPKG referenced this pull request in khulnasoft/kuttl Mar 20, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants