-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add unit under test declaration KEP. #3
Conversation
Signed-off-by: jbarrick@mesosphere.com <jbarrick@mesosphere.com>
db84951
to
52acc84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition! One potential implentation detail not mentioned here is logging of multiple background commands. The solution should ensure that users can distinguish between the output of different background commands.
Oh yes, that's a great point. I'll add some details here. |
I need to think about that a little bit @nfnt. We're going to want to label the output, something like:
If we want to the label the output, what do we think would be the best thing to label it with?
The other option might be to colorize each command's output differently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great write up! I'm good with merging as draft or provisional.
I would like one of the alternatives as a preference... it feels like command
in isolation is really abstract. I think I like controller
or controller-command
. OR something that more clearly indicates that this is a "setup" command. Perhaps we need additional normal testing lifecycle hooks as well... setupSuite, setup, teardown, teardownSuite?
👍 to merging as draft. @jbarrick-mesosphere if you're OK driving this forward to implementation, work can start on the comments and implementation in the next PR. |
No description provided.