Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Annotate container image with github source #391

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

gberche-orange
Copy link
Contributor

What this PR does / why we need it:

Fixes #390

@gberche-orange gberche-orange changed the title Annote container image with github source Annotate container image with github source Oct 20, 2022
@kensipe
Copy link
Member

kensipe commented Oct 25, 2022

This seems pretty straight forward... @gberche-orange could you sign your commit for DCO?

@gberche-orange
Copy link
Contributor Author

Thanks @kensipe

Sorry for the lack of DCO signoff from my commit originated from github web ui. This is now fixed.

ps: I've rebased the commit (git rebase --signoff HEAD~1) and configured my works to require sign-offs for

So, hopefully my next commits won't be missing DCO again.

@gberche-orange
Copy link
Contributor Author

It might be possible that if the /kudobuilder/kuttl repo or /kudobuilder org enables the Require contributors to sign off on web-based commits option, then any new fork would automatically inherit from this option, and offer by default to sign off commits made through GH web UI.

@kensipe
Copy link
Member

kensipe commented Nov 2, 2022

thanks for patience... I've taken to long to get to this. I will review tomorrow this and the other PRs... really appreciate the contributions!

Copy link
Contributor

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\lgtm

@porridge
Copy link
Member

Oh no, I clicked the button to refresh the branch and now the DCO check fails! 😭
@gberche-orange would it be too much if I asked you to please rebase your commit?

closes kudobuilder#390

Signed-off-by: Guillaume Berche <guillaume.berche@orange.com>
Co-authored-by: Erik Godding Boye <egboye@gmail.com>
Signed-off-by: Guillaume Berche <guillaume.berche@orange.com>
@gberche-orange
Copy link
Contributor Author

@porridge sure, np, rebased and squashed in ce0a883

@porridge porridge merged commit 16330d4 into kudobuilder:main Nov 28, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OCI label org.opencontainers.image.source to oci image
4 participants