Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: handle redundant deletion of Namespace #566

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

kumar-mallikarjuna
Copy link
Contributor

What this PR does / why we need it:
Adds an IsNotFound check before attempting to delete the Case's Namespace.

Fixes #565

@porridge
Copy link
Member

Sorry, I made a mess with the sign-off again 🤦🏻

@kumar-mallikarjuna
Copy link
Contributor Author

Hey @porridge , might need to fix your sign-off here 😅

@porridge
Copy link
Member

Hey @porridge , might need to fix your sign-off here 😅

Yes, but unfortunately I'm not able to do it myself. GitHub allows me to push a commit to your repo's branch based on a review suggestion (which is what I did, but used the wrong email) but it will not allow me to rewrite that commit. Sorry but I'll have to ask you to squash that commit into yours.

Signed-off-by: Kumar Mallikarjuna <kumarmallikarjuna.work@gmail.com>
@kumar-mallikarjuna
Copy link
Contributor Author

Done, @porridge .

@porridge porridge merged commit e598762 into kudobuilder:main Sep 27, 2024
5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Deleting test namespace throws an error in-case of multiple TestSteps with lazy-loading Kubeconfigs
2 participants