Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove dependency to shoulda-matchers gem #57

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Remove dependency to shoulda-matchers gem #57

merged 1 commit into from
Dec 10, 2019

Conversation

machupicchubeta
Copy link
Contributor

The test codes seems NOT to be depended on it.
How about removing dependency to shoulda-matcher gem?

Ref.

@machupicchubeta machupicchubeta requested a review from a team as a code owner December 9, 2019 09:23
@ghost ghost requested review from AtsushiM and tknzk and removed request for a team December 9, 2019 09:23
tknzk
tknzk approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@tknzk tknzk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks for the update.
merged it.

@tknzk tknzk merged commit 24b7cce into kufu:master Dec 10, 2019
@machupicchubeta
Copy link
Contributor Author

Thank you! 🍶

@machupicchubeta machupicchubeta deleted the how_about_removing_dependency_to_shoulda-matchers_gem branch December 10, 2019 02:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tknzk tknzk tknzk approved these changes

@AtsushiM AtsushiM Awaiting requested review from AtsushiM

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@machupicchubeta @tknzk