Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

tzinfoの更新準備(Integer#months -> Date#prev_month) #89

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

motsat
Copy link
Member

@motsat motsat commented Jul 27, 2022

tzinfoの更新により、ActiveSupportが読まれなくなりInteger#monthsがそのままでは使えなくなるので事前にDate#prev_monthに置き換えておきます。
#88

@motsat motsat requested a review from a team as a code owner July 27, 2022 23:34
@motsat motsat requested review from f440 and meganemura and removed request for a team July 27, 2022 23:34
@meganemura meganemura changed the title tzinfoの更新準備(Integer#months -> Integer#prev_month) tzinfoの更新準備(Integer#months -> Date#prev_month) Jul 28, 2022
Copy link
Member

@meganemura meganemura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meganemura
Copy link
Member

gemspec で activesupport を依存に入れているので lib/kirico.rb で明示的に require 'activesupport' するというのでもいいカモ。

Copy link
Member

@f440 f440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@f440 f440 merged commit 95e1961 into kufu:master Jul 28, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants