Ruby 3系のキーワード引数非互換に備える #90
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motsat
requested review from
AtsushiM,
marumarism,
f440 and
meganemura
and removed request for
a team and
marumarism
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
以下のPRでrspecが失敗しており、失敗しないための事前の修正です。
#88
失敗の原因はRuby 3.0でHashからキーワード引数への変換が非互換になったのが原因のようでした。
https://www.ruby-lang.org/ja/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/
そのため、double splat演算子（**）での対応をしました。
この修正を行っておけば、失敗していたPR(#88)もRuby2.7/3.0/3.1でrspecが通ることも事前に確認しました。