Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs(MADR): mesh logging madr initial proposal #4908

Merged
merged 14 commits into from
Sep 7, 2022

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Aug 25, 2022

Rendered version for better viewing: https://github.com/slonka/kuma/blob/docs/mesh-logging/docs/madr/decisions/008-mesh-logging.md#meshlogging

closes #4733

Signed-off-by: slonka slonka@users.noreply.github.com

Checklist prior to review

  • Link to docs PR or issue -- pr is itself docs
  • Link to UI issue or PR -- not ui issue
  • Is the issue worked on linked? -- yes
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests -- docs
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here? -- added entry to roll up this with implementation, let me know if it's wrong

Changelog: feat(policy): Add MeshAccessLog policy

Signed-off-by: slonka <slonka@users.noreply.github.com>
…options, explain matching levels better [ci skip]

Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka marked this pull request as ready for review August 26, 2022 11:36
@slonka slonka requested a review from a team as a code owner August 26, 2022 11:36
@slonka slonka changed the title docs(MADR): mesh logging madr initial proposal [ci skip] docs(MADR): mesh logging madr initial proposal Aug 26, 2022
docs/madr/decisions/008-mesh-logging.md Outdated Show resolved Hide resolved
docs/madr/decisions/008-mesh-logging.md Outdated Show resolved Hide resolved
docs/madr/decisions/008-mesh-logging.md Show resolved Hide resolved
docs/madr/decisions/008-mesh-logging.md Outdated Show resolved Hide resolved
docs/madr/decisions/008-mesh-logging.md Outdated Show resolved Hide resolved
docs/madr/decisions/008-mesh-logging.md Outdated Show resolved Hide resolved
docs/madr/decisions/008-mesh-logging.md Show resolved Hide resolved
docs/madr/decisions/008-mesh-logging.md Outdated Show resolved Hide resolved
docs/madr/decisions/008-mesh-logging.md Show resolved Hide resolved
docs/madr/decisions/008-mesh-logging.md Outdated Show resolved Hide resolved
docs/madr/decisions/008-mesh-logging.md Outdated Show resolved Hide resolved
docs/madr/decisions/008-mesh-logging.md Outdated Show resolved Hide resolved
docs/madr/decisions/008-mesh-logging.md Show resolved Hide resolved
Copy link
Contributor

@lobkovilya lobkovilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! It would be good to see examples when the mesh operator defines logging for the whole mesh and the service owner somehow changes this behavior

docs/madr/decisions/008-mesh-logging.md Outdated Show resolved Hide resolved
docs/madr/decisions/008-mesh-logging.md Outdated Show resolved Hide resolved
docs/madr/decisions/008-mesh-logging.md Outdated Show resolved Hide resolved
docs/madr/decisions/008-mesh-logging.md Outdated Show resolved Hide resolved
docs/madr/decisions/008-mesh-logging.md Outdated Show resolved Hide resolved
slonka and others added 2 commits August 30, 2022 11:19
Co-authored-by: Ilya Lobkov <lobkovilya@yandex.ru>
Signed-off-by: Krzysztof Słonka <slonka@users.noreply.github.com>
Co-authored-by: Ilya Lobkov <lobkovilya@yandex.ru>
Signed-off-by: Krzysztof Słonka <slonka@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2022

Codecov Report

Merging #4908 (93be1f2) into master (e6abbbe) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4908      +/-   ##
==========================================
- Coverage   46.68%   46.67%   -0.01%     
==========================================
  Files         687      687              
  Lines       46656    46656              
==========================================
- Hits        21781    21777       -4     
- Misses      22966    22969       +3     
- Partials     1909     1910       +1     
Impacted Files Coverage Δ
pkg/core/resources/manager/cache.go 83.11% <0.00%> (-5.20%) ⬇️
pkg/xds/cache/once/cache.go 82.05% <0.00%> (-5.13%) ⬇️
pkg/xds/cache/once/once.go 95.00% <0.00%> (-5.00%) ⬇️
pkg/gc/finalizer.go 78.26% <0.00%> (+4.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka marked this pull request as draft August 31, 2022 09:22
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
…t believe that is the case [ci skip]

Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka marked this pull request as ready for review September 5, 2022 08:03
…kip]

Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good to me!

I guess we should really focus on supporting inline backend and then add the reference type and the global type just to make sure we ship something right?

@slonka
Copy link
Contributor Author

slonka commented Sep 7, 2022

I guess we should really focus on supporting inline backend and then add the reference type and the global type just to make sure we ship something right?

Yes! Let's do this in that order!

@slonka slonka merged commit d241e47 into kumahq:master Sep 7, 2022
@slonka slonka deleted the docs/mesh-logging branch September 7, 2022 07:28
@lahabana
Copy link
Contributor

lahabana commented Sep 7, 2022

@slonka just a process detail MADR are meant to be approved by 3 people :)

@slonka
Copy link
Contributor Author

slonka commented Sep 7, 2022

@lahabana I forgot about that :/ - should I revert?

@lahabana
Copy link
Contributor

lahabana commented Sep 7, 2022

No it's fine I think we had a bunch of verbal approvals (probably might be useful to get the approval after the merge now :))

@lahabana lahabana mentioned this pull request Sep 7, 2022
1 task
@lukidzi
Copy link
Contributor

lukidzi commented Sep 7, 2022

LGTM

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New TrafficLog design (new name: MeshLogging)
8 participants