-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
docs(MADR): mesh logging madr initial proposal #4908
Conversation
Signed-off-by: slonka <slonka@users.noreply.github.com>
…options, explain matching levels better [ci skip] Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start! It would be good to see examples when the mesh operator defines logging for the whole mesh and the service owner somehow changes this behavior
Co-authored-by: Ilya Lobkov <lobkovilya@yandex.ru> Signed-off-by: Krzysztof Słonka <slonka@users.noreply.github.com>
Co-authored-by: Ilya Lobkov <lobkovilya@yandex.ru> Signed-off-by: Krzysztof Słonka <slonka@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #4908 +/- ##
==========================================
- Coverage 46.68% 46.67% -0.01%
==========================================
Files 687 687
Lines 46656 46656
==========================================
- Hits 21781 21777 -4
- Misses 22966 22969 +3
- Partials 1909 1910 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
…t believe that is the case [ci skip] Signed-off-by: slonka <slonka@users.noreply.github.com>
…kip] Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good to me!
I guess we should really focus on supporting inline backend and then add the reference type and the global type just to make sure we ship something right?
Yes! Let's do this in that order! |
@slonka just a process detail MADR are meant to be approved by 3 people :) |
@lahabana I forgot about that :/ - should I revert? |
No it's fine I think we had a bunch of verbal approvals (probably might be useful to get the approval after the merge now :)) |
LGTM |
Rendered version for better viewing: https://github.com/slonka/kuma/blob/docs/mesh-logging/docs/madr/decisions/008-mesh-logging.md#meshlogging
closes #4733
Signed-off-by: slonka slonka@users.noreply.github.com
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
? --> Changelog:
entry here? -- added entry to roll up this with implementation, let me know if it's wrong