Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(kumacp): mesh access log - proto + validation #4998

Merged
merged 27 commits into from
Sep 15, 2022
Merged

feat(kumacp): mesh access log - proto + validation #4998

merged 27 commits into from
Sep 15, 2022

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Sep 13, 2022 •
edited by lukidzi
Loading

Part of #4979

Checklist prior to review

Changelog: feat(kumacp) new mesh access log policy

  • Link to docs PR or issue -- this is not implem yet so docs pr will be in that PR
  • Link to UI issue or PR -- not a UI issue
  • Is the issue worked on linked? -- yes
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) -- yes
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS -- yes
  • Unit Tests -- yes
  • E2E Tests -- not yet, not implem
  • Manual Universal Tests -- not yet
  • Manual Kubernetes Tests -- not yet
  • Do you need to update UPGRADE.md? -- nope
  • Does it need to be backported according to the [backporting policy] (../blob/master/CONTRIBUTING.md#backporting)? -- no
  • Do you need to explicitly set a > Changelog: entry here?

Changelog: feat(policy): Add MeshAccessLog policy

@slonka
feat(kumacp): bootstrap new policy
24c8bf3 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(kumacp): modify policy
aae1085 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(kumacp): update madr formats
a9c4a73 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(kumacp): make full mesh access log example pass validator
e871718 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(kumacp): more validations
10096a0 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(kumacp): more validations
a5d9cfb 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(kumacp): more validations - tcp and reference
af672ba 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(kumacp): more validations - to and mesh gateway route
6e738fc 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(kumacp): more validations - default must be defined
b49d532 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(kumacp): update madr
6d986d1 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka changed the title feat(kumacp) mesh access log implementation feat(kumacp) mesh access log - proto + validation Sep 13, 2022
@slonka
feat(kumacp): make check pass
bc3f09a 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(kumacp): make check pass
8f47948 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(kumacp): make policies stable
d10ea43 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(kumacp): make check pass
14f0759 
Signed-off-by: slonka <slonka@users.noreply.github.com>
slonka
slonka commented Sep 13, 2022
View reviewed changes
mk/generate.mk Show resolved Hide resolved
@slonka
feat(kumacp): update golden files
d5a86ab 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@lahabana
Copy link
Contributor

I might have not socialized enough that we shouldn't spend time implementing kumactl for new policies. We'll do a separate task to make these not a bunch of copy paste.

@slonka
Copy link
Contributor Author

slonka commented Sep 13, 2022 •
edited
Loading

I might have not socialized enough that we shouldn't spend time implementing kumactl for new policies. We'll do a separate task to make these not a bunch of copy paste.

@lahabana - I did not manually implement kumactl for this. I've just run make check and make test UPDATE_GOLDEN_FILES=true and that's what got generated. Otherwise those targets failed. The only files I touched manually are marked with my comments above.

@lahabana
Copy link
Contributor

Ha cool :)

@slonka
Copy link
Contributor Author

slonka commented Sep 13, 2022 •
edited
Loading

Should I change skip_registration to true?

@slonka
feat(kumacp): skip registration
dd9b3c4 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(kumacp): skip registration 2
cb8f771 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
Copy link
Contributor Author

slonka commented Sep 13, 2022

I've changed it to true since it made the CI pass.

@slonka slonka marked this pull request as ready for review September 13, 2022 13:47
@slonka slonka requested a review from a team as a code owner September 13, 2022 13:47
@slonka slonka changed the title feat(kumacp) mesh access log - proto + validation feat(kumacp): mesh access log - proto + validation Sep 13, 2022
@slonka @lahabana
Apply suggestions from code review
98f71c0 
Co-authored-by: Charly Molter <charly@molter.io>
Signed-off-by: Krzysztof Słonka <slonka@users.noreply.github.com>
@slonka
Copy link
Contributor Author

slonka commented Sep 14, 2022

Should I change skip_registration to true?

@lobkovilya what are the implications of skip_registration set to true and do you know why it makes the CI crash if it's set to false?

@slonka
feat(kumacp): fix typos in test assertions
4d17bd1 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(kumacp): rename mesh access log types
e6f55e6 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(kumacp): change skip_registration to false
d16bcb4 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(kumacp): update golden files
0ae60d7 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(kumacp): add validations for file and tcp backend
39a475d 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(kumacp): add validation for reference
08c9767 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(kumacp): remove reference since it's not for this stage, this co…
99b4203 
…mmit can be reverted

Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(kumacp): make check pass
ec79f37 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(kumacp): update golden files
b20824e 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka mentioned this pull request Sep 14, 2022
Closed
@slonka
Copy link
Contributor Author

slonka commented Sep 14, 2022

Be aware of the fact that I removed reference since we agreed that for the first iteration we will not support this. This commit can be reverted when we go back to implementing it.

@slonka slonka mentioned this pull request Sep 15, 2022
Closed
1 task
@slonka slonka merged commit 8b24b44 into kumahq:master Sep 15, 2022
@slonka slonka deleted the feat/mesh-access-log-implem branch September 15, 2022 06:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lobkovilya lobkovilya lobkovilya approved these changes

@lahabana lahabana lahabana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slonka @lahabana @lobkovilya